Swizzle RCTUIManager #4619
Merged
Swizzle RCTUIManager #4619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kmagiera
reviewed
Jun 28, 2023
| if (self = [super init]) { | ||
| _animationsManager = animationsManager; | ||
| _uiManager = uiManager; | ||
| _reaUIManager = self; |
There was a problem hiding this comment.
I don't quite understand the need for this whole REASwizzledUIManager class to exists. Also, assigning singletons like that seem a bit risky.
It seem to me that the reason it's been done this way was for the swizzled methods to be able to access _uiManager and _animationsManager fields. I think the former can just be replaced by self as the swizzling concept refers to swapping out implementation of certain methods. The UI manager object will be the same and the swizzled method self will refer to it.
As for the latter field, the best way IMO would be to use category on UIManager class that adds animationsManager property to it using associated object technique (https://nshipster.com/associated-objects/)
There was a problem hiding this comment.
- I've made the changes based on your suggestions 👍. I dumped the singleton and used associated objects with the category instead.
- The only reason I created the
REASwizzledUIManagerclass was to keep the swizzled methods separate from the animation manager. I didn't want to put everything into one file. But yeah, if you think it's best, I can move the_manageChildrenand_uiBlockWithLayoutUpdateForRootViewmethods back to theREAAnimationManagerclass.
…ansion/react-native-reanimated into @piaskowyk/UIManager-refactor
tomekzaw
reviewed
Jul 5, 2023
Latropos
pushed a commit
that referenced
this pull request
Jul 13, 2023
## Summary Recently, we began rewriting the iOS initialization process. Tomek moved the injection of JSI bindings to `installTurboModule` (check out #4523) and then used swizzling to eliminate the `REAEventDispatcher` (see #4576). More context here: expo/expo#23057 (comment) This PR removed UIManager overriding by swizzling the `_manageChildren` and `uiBlockWithLayoutUpdateForRootView` methods. These changes allowed us to get rid of `RCTAppDelegate+Reanimated`, `UIResponder+Reanimated`, and `REAInitializer`. For now, we're gonna leave `REAInitializer` as deprecated for a few more releases to maintain backward compatibility. But just a heads up, we'll be removing it in the future. ## Test plan - I tested building on different react native versions by CI https://github.com/piaskowyk/reanimated-rn-version-tester/actions/runs/5375166823 - Tested Layout Animations on Example app form main branch.
3 tasks
gabrieldonadel
added a commit
to expo/expo
that referenced
this pull request
Oct 25, 2023
# Why update vendoring modules for SDK 50 + this will produce way less diffs when upgrading for react-native 0.73 support # How - `et uvm -m react-native-reanimated -c 3.5.4` - Updated `EXVersionUtils.mm` given that REAEventDispatcher and REAUIManager no longer exist (software-mansion/react-native-reanimated#4619) # Test Plan - unversioned expo go + ncl reanimated - versioned expo go + ncl reanimated # Checklist - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Kudo Chien <kudo@expo.dev>
marklawlor
pushed a commit
to expo/expo
that referenced
this pull request
Oct 30, 2023
# Why update vendoring modules for SDK 50 + this will produce way less diffs when upgrading for react-native 0.73 support # How - `et uvm -m react-native-reanimated -c 3.5.4` - Updated `EXVersionUtils.mm` given that REAEventDispatcher and REAUIManager no longer exist (software-mansion/react-native-reanimated#4619) # Test Plan - unversioned expo go + ncl reanimated - versioned expo go + ncl reanimated # Checklist - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Kudo Chien <kudo@expo.dev>
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 11, 2024
## Summary In #4619 @piaskowyk removed `REAInitializer` because it was no longer required. To avoid a breaking change, in #4880 he restored `REAInitializer` with no-op implementation for backward compatibility. This PR removes `REAInitializer` which effectively does nothing since 3.5.0. ## Test plan Build Example app on iOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently, we began rewriting the iOS initialization process. Tomek moved the injection of JSI bindings to
installTurboModule(check out #4523) and then used swizzling to eliminate theREAEventDispatcher(see #4576). More context here: expo/expo#23057 (comment)This PR removed UIManager overriding by swizzling the
_manageChildrenanduiBlockWithLayoutUpdateForRootViewmethods. These changes allowed us to get rid ofRCTAppDelegate+Reanimated,UIResponder+Reanimated, andREAInitializer.For now, we're gonna leave
REAInitializeras deprecated for a few more releases to maintain backward compatibility. But just a heads up, we'll be removing it in the future.Test plan