Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed children disappearing on transition.change #483

Merged
merged 2 commits into from
Nov 28, 2019
Merged

fixed children disappearing on transition.change #483

merged 2 commits into from
Nov 28, 2019

Conversation

CameronStuartSmith
Copy link
Contributor

Fix relating to #272. Stops children from disappearing on transition.

@CameronStuartSmith
Copy link
Contributor Author

Changes in TransitionUtils.java fixes both #272 & #257
Changes in ChangeTransition.java fixed only #272 but are no longer needed ( The transition util changed removed the need for ChangeTransition.java )

@adkenyon
Copy link
Contributor

This fixes #272 for our app.

@neopit
Copy link

neopit commented Nov 27, 2019

This fixes our issue on our app as well.
That fixed issue we encountered with Transition change and issue on zIndex.

I will be happy to see this fix approve.
Thx for the fix.

@osdnk
Copy link
Contributor

osdnk commented Nov 28, 2019

Thanks! It helps!

@osdnk osdnk merged commit 4282626 into software-mansion:master Nov 28, 2019
@osdnk
Copy link
Contributor

osdnk commented Nov 28, 2019

closes #272, #257

@tijunoi
Copy link

tijunoi commented Nov 28, 2019

I was installing the library from the PR head to try if it solved my issues and it did. I've seen it was just merged to master. May I ask how long will it take to be released in npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants