Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix EQ and NEQ operators. #498

Merged
merged 3 commits into from
Dec 17, 2019
Merged

[Android] Fix EQ and NEQ operators. #498

merged 3 commits into from
Dec 17, 2019

Conversation

Szymon20000
Copy link
Contributor

Related to: #495

jakub-gonet
jakub-gonet approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@jakub-gonet jakub-gonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

jakub-gonet
jakub-gonet requested changes Dec 12, 2019
View reviewed changes
Copy link
Member

@jakub-gonet jakub-gonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, could you also update NEQ node?
android/src/main/java/com/swmansion/reanimated/nodes/OperatorNode.java#216

@jakub-gonet jakub-gonet mentioned this pull request Dec 12, 2019
Closed
@wcandillon
Copy link
Contributor

Could the tests from #495 be added to this PR?

@Szymon20000 Szymon20000 changed the title [Android] Fix EQ operator. [Android] Fix EQ and NEQ operators. Dec 13, 2019
@osdnk @jakub-gonet
Update android/src/main/java/com/swmansion/reanimated/nodes/OperatorN…
f1431db 
…ode.java

Co-Authored-By: Jakub <jakub.gonet@swmansion.com>
@osdnk osdnk merged commit 59bd121 into master Dec 17, 2019
@osdnk osdnk deleted the @szymon/fix_eq branch December 17, 2019 17:51
@osdnk osdnk mentioned this pull request Jan 15, 2020
Merged
osdnk added a commit that referenced this pull request Jan 15, 2020
@osdnk
Handle issue in eq and neq when any of params is null (#552)
74beaa3 
Fixes regression made by 59bd121

Closes #551

We have observed that while evaluating neq or eq, the second param might be null. After #498 it started causing NullPointerException so I made a special check for that. Additionally, I allowed the first param to be nullable as well.
This was referenced Feb 6, 2020
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 28, 2020
Merged
This was referenced Apr 6, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-gonet jakub-gonet jakub-gonet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Szymon20000 @wcandillon @jakub-gonet @osdnk