-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align with new layoutWithAffectedShadowViews on react-native@0.73 #5204
align with new layoutWithAffectedShadowViews on react-native@0.73 #5204
Conversation
after the changes introduced in this PR it builds fine, I have no clue if there are any side effects somewhere else |
- assuming this will be released in react-native@0.73
I believe this can be safely merged now when facebook/react-native#40748 gets merged 😄. We don't know if this will be included in 0.73 or 0.72.x though 🤷 |
Hey folks, the PR on rn repo has been merged, please read this comment from @NickGerleman: facebook/react-native#40748 (comment) it will land on 0.73 edit: adding the stacktrace just in case someone falls in here from search:
|
The commit changing the signature of |
Closing this since it's already included in the 0.73 PR: #4913 (comment) |
But overall I appreciate your PR and really thanks for the help ❤️ |
@piaskowyk anytime! thanks for your hard work! |
There is an open PR with changes for calculating onLayout on iOS on Paper: facebook/react-native#40748
This PR aligns reanimated with these changes.