Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align with new layoutWithAffectedShadowViews on react-native@0.73 #5204

Conversation

efstathiosntonas
Copy link
Contributor

@efstathiosntonas efstathiosntonas commented Oct 10, 2023

There is an open PR with changes for calculating onLayout on iOS on Paper: facebook/react-native#40748

This PR aligns reanimated with these changes.

@efstathiosntonas
Copy link
Contributor Author

after the changes introduced in this PR it builds fine, I have no clue if there are any side effects somewhere else

@efstathiosntonas efstathiosntonas changed the title [DO NOT MERGE] fix for new onLayout calculations on iOS [DO NOT MERGE] fix for new onLayout calculations on iOS (Paper) Oct 10, 2023
- assuming this will be released in react-native@0.73
@efstathiosntonas
Copy link
Contributor Author

efstathiosntonas commented Oct 10, 2023

I believe this can be safely merged now when facebook/react-native#40748 gets merged 😄. We don't know if this will be included in 0.73 or 0.72.x though 🤷

@efstathiosntonas
Copy link
Contributor Author

efstathiosntonas commented Oct 10, 2023

Hey folks, the PR on rn repo has been merged, please read this comment from @NickGerleman:

facebook/react-native#40748 (comment)

it will land on 0.73

edit: adding the stacktrace just in case someone falls in here from search:

Cannot initialize a parameter of type 'NSPointerArray *' with an lvalue of type 'NSHashTable<RCTShadowView *> *__strong'

@NickGerleman
Copy link

NickGerleman commented Oct 14, 2023

The commit changing the signature of layoutWithAffectedShadowViews has been picked into 0.73-stable and will be part of 0.73.0-rc.3: facebook/react-native@3168055

@efstathiosntonas efstathiosntonas changed the title [DO NOT MERGE] fix for new onLayout calculations on iOS (Paper) align with new layoutWithAffectedShadowViews on react-native@0.73 Oct 14, 2023
@efstathiosntonas efstathiosntonas marked this pull request as ready for review October 14, 2023 09:16
@efstathiosntonas
Copy link
Contributor Author

efstathiosntonas commented Oct 30, 2023

Closing this since it's already included in the 0.73 PR: #4913 (comment)

@piaskowyk
Copy link
Member

But overall I appreciate your PR and really thanks for the help ❤️

@efstathiosntonas
Copy link
Contributor Author

@piaskowyk anytime! thanks for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants