Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Added support for callID #547

Merged

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Jan 14, 2020

Why

  • fixes "test" example - all boxes animate across the screen
  • fixes "interpolate" example - now boxes don't jitter when you drag them
  • fixes "colors" example - now colors interpolate smoothly rather than snap to highest RGB
  • fixes "image viewer" example - no more jittering when the user stops panning
  • fixes snapping to edges in "chat heads" example - doesn't fix the bug where other chat heads don't follow the main one
  • changes "different spring configs" to go from jittery circles to not moving circles (¯\_(ツ)_/¯)
  • doesn't fix any of the interactable examples

How

Adding more JS support for the features added by this PR #354 we should be more careful in the future not to add native-only features.

Issue:

Screen Shot 2020-01-14 at 3 46 32 PM

@EvanBacon EvanBacon requested a review from osdnk January 14, 2020 23:54
Copy link
Contributor

@osdnk osdnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some notes, but nothing's blocking.

src/core/AnimatedCallFunc.js Show resolved Hide resolved
src/core/AnimatedNode.js Outdated Show resolved Hide resolved
src/core/AnimatedValue.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants