Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistakes in example app #6069

Closed
wants to merge 1 commit into from
Closed

Fix mistakes in example app #6069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...src/examples/PerfomanceMonitorExample.tsx → ...rc/examples/PerformanceMonitorExample.tsx
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions app/src/examples/ShareableFreezingExample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ export default function FreezingShareables() {
/>
</View>
<View style={styles.textAndButton}>
<Text style={styles.text}>🤫</Text>
<Text style={styles.text}>⚠️</Text>
<Button
title="Modify converted remote function"
onPress={tryModifyConvertedRemoteFunction}
/>
</View>
<View style={styles.textAndButton}>
<Text style={styles.text}>⚠️</Text>
<Text style={styles.text}>🤫</Text>
<Button
title="Modify converted host object"
onPress={tryModifyConvertedHostObject}
Expand Down Expand Up @@ -75,7 +75,7 @@ export default function FreezingShareables() {
function tryModifyConvertedArray() {
const obj = [1, 2, 3];
makeShareableCloneRecursive(obj);
obj[0] = 2; // should warn beacuse it's frozen
obj[0] = 2; // should warn because it's frozen
}

function tryModifyConvertedRemoteFunction() {
Expand Down
3 changes: 2 additions & 1 deletion app/src/examples/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ import WorkletFactoryCrash from './WorkletFactoryCrashExample';
import RuntimeTestsExample from './RuntimeTests/RuntimeTestsExample';
import HabitsExample from './LayoutAnimations/HabitsExample';
import MemoExample from './MemoExample';
import PerformanceMonitorExample from './PerfomanceMonitorExample';
import PerformanceMonitorExample from './PerformanceMonitorExample';
import ScreenTransitionExample from './ScreenTransitionExample';
import ComposedHandlerConditionalExample from './ComposedHandlerConditionalExample';
import ComposedHandlerDifferentEventsExample from './ComposedHandlerDifferentEventsExample';
Expand Down Expand Up @@ -249,6 +249,7 @@ export const EXAMPLES: Record<string, Example> = {
icon: '📺',
title: 'Screen transition',
screen: ScreenTransitionExample,
missingOnFabric: true,
},

// Basic examples
Expand Down
3 changes: 3 additions & 0 deletions cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"barfoo",
"bfrg",
"bridgeless",
"bokeh",
"chlgm",
"coef",
"collapsable",
Expand Down Expand Up @@ -42,6 +43,8 @@
"runtimes",
"overdamped",
"automagically",
"shareables",
"swipeable",
"threejs",
"nomalized"
],
Expand Down