Layout Transition test #6168
Merged
Layout Transition test #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
reviewed
Jun 27, 2024
apps/common-app/src/examples/RuntimeTests/tests/layoutAnimations/layout/testComponents.test.tsx
Outdated
Show resolved
Hide resolved
...mon-app/src/examples/RuntimeTests/tests/layoutAnimations/layout/predefinedLayoutPosition.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/src/layoutReanimation/defaultTransitions/FadingTransition.ts
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/layoutAnimations/layout/testComponents.test.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/examples/RuntimeTests/tests/layoutAnimations/layout/testComponents.test.tsx
Outdated
Show resolved
Hide resolved
piaskowyk
approved these changes
Jun 28, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Now the fading transition executes for `2*duration` miliseconds. We should divide the duration by 2 to fix it, the same way it done for the following transitions: https://github.com/software-mansion/react-native-reanimated/blob/82d1d9582d96b463ab95d6ba9b8c1c20e7aa867b/packages/react-native-reanimated/src/layoutReanimation/defaultTransitions/JumpingTransition.ts#L33 https://github.com/software-mansion/react-native-reanimated/blob/82d1d9582d96b463ab95d6ba9b8c1c20e7aa867b/packages/react-native-reanimated/src/layoutReanimation/defaultTransitions/SequencedTransition.ts#L44 <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> Also I rename the variables that hold half of the duration and are named "duration" into "halfDuration", as it was suggested during the review ## Test plan Tests are in this PR: #6168 <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
This was referenced Jul 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
## Summary Tests added in PR: #6168 verify layout transition of component changing position only. In this PR I verify cases when both position and size change. ## Test plan <img width="360" alt="image" src="https://github.com/user-attachments/assets/45b19deb-1001-401b-b309-ad86f092b3f0">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create tests of LAYOUT TRANSITIONS
Tests include:
Test plan