Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove header to fix broken tests on android #6289

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jul 18, 2024

Summary

The height of information "Reload the app to run the tests again" was causing broken tests on android. This height was included in results of getViewProp("top") including snapshotsBEFORE:
image
AFTER:
image

Test plan

Latropos added 4 commits July 18, 2024 10:13

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Latropos Latropos marked this pull request as ready for review July 18, 2024 08:30
@Latropos Latropos requested a review from tjzel July 18, 2024 08:30
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do one of the following:

  1. Restore the text with position:absolute so it doesn't affect layout.

  2. Make the text appear after the tests are finished - probably with some callback that will notify the component.

@Latropos Latropos requested a review from tjzel July 18, 2024 10:13
@Latropos Latropos added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit d1c0f27 Jul 18, 2024
5 checks passed
@Latropos Latropos deleted the acynk/fix-header-android branch July 18, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants