Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump prettier #6486

Merged
merged 1 commit into from
Sep 6, 2024
Merged

chore: Bump prettier #6486

merged 1 commit into from
Sep 6, 2024

Conversation

tjzel
Copy link
Collaborator

@tjzel tjzel commented Sep 5, 2024 •
edited by github-actions bot
Loading

Summary

  • Applied new formatting.
  • Added global .prettierignore for build so prettier won't try to format .jsons generated by Android

Test plan

🚀

This was referenced Sep 5, 2024
Merged
Merged
MatiPl01
MatiPl01 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@MatiPl01 MatiPl01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that prettier adds these unnecessary commas, but if it's not configurable then it doesn't matter to me.

@tjzel tjzel added this pull request to the merge queue Sep 6, 2024
Merged via the queue into main with commit 018b7a0 Sep 6, 2024
17 checks passed
@tjzel tjzel deleted the @tjzel/bump-prettie branch September 6, 2024 16:48
github-merge-queue bot pushed a commit that referenced this pull request Sep 8, 2024
@tjzel
chore: Enable TSDoc and JSDoc formatting (#6484)
9e5bdc1 
## Summary

Requires:

- #6486 

## Test plan
github-merge-queue bot pushed a commit that referenced this pull request Sep 8, 2024
@tjzel
chore: Enable .js TypeScript checks in repo (#6483)
4a99693 
## Summary

Currently .js files weren't type checked. This PR adds type-checking for
them alongside with necessary JSDoc comments.

Requires:
- #6486
- #6487
- #6485

## Test plan

🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@MatiPl01 MatiPl01 MatiPl01 approved these changes

@Latropos Latropos Awaiting requested review from Latropos

@szydlovsky szydlovsky Awaiting requested review from szydlovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjzel @tomekzaw @MatiPl01