Runtime snapshot runtime tests of Layout Animation on fabric #6538
Conversation
Latropos
changed the title
Latropos
changed the title
| @@ -23,6 +23,7 @@ type NativeUpdate = { | |||
| export function createUpdatesContainer() { | |||
| const jsUpdates = makeMutable<Array<JsUpdate>>([]); | |||
| const nativeSnapshots = makeMutable<Array<NativeUpdate>>([]); | |||
| const brokenNativeSnapshotsOnFabric = makeMutable(false); | |||
There was a problem hiding this comment.
| const brokenNativeSnapshotsOnFabric = makeMutable(false); | |
| const unimplementedNativeSnapshotsOnFabric = makeMutable(false); |
| // TODO Implement native snapshots for layout animations on Fabric | ||
| _updateNativeSnapshot([{ tag, update }], jsUpdates.value.length - 1); | ||
| } else { | ||
| brokenNativeSnapshotsOnFabric.value = true; |
There was a problem hiding this comment.
I think you can safely move this assignment to the createUpdatesContainer method.
There was a problem hiding this comment.
This would have some negative side effects, for example it would broke this test:
Cause only in case of layout animations the native snapshots are unimplemented, so we can assume that if function notifyAboutProgress has never been called, then native snapshots work fine on fabric.
| if (_IS_FABRIC && (-1) in sortedUpdates) { | ||
| return sortedUpdates[-1]; | ||
| } |
There was a problem hiding this comment.
This is something we need to verify. Does it happen all the time or just sometimes? Additionally, it will break in cases where we want to test animations for more than one component.
| if ((key as string) === 'opacity' && jsValue === 1 && nativeValue === undefined) { | ||
| // undefined opacity may get translated into 1, as it is the default value | ||
| valuesAreMatching = true; | ||
| } |
There was a problem hiding this comment.
Also, here we need to verify why in the JS update, we can receive undefined values
There was a problem hiding this comment.
In our layout animations we use function maybeRestoreOpacity a lot. After the restoration the opacity is explicitly defined as 1, even if it had been undefined.
Summary
Snapshots of layout animations were not implemented for fabric (as layout animations were not implemented). In this PR I enable JS snapshots for fabric layout animations.
Test plan