refactor(Worklets): Move messageQueue to Worklets
#6577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
changed the base branch from
main
to
@tjzel/worklets/move-shareables-to-worklets
tjzel
force-pushed
the
@tjzel/worklets/move-message-queue-to-worklets
branch
from
f50fb59 to
19251ba
Compare
tjzel
force-pushed
the
@tjzel/worklets/move-shareables-to-worklets
branch
from
87fd1fd to
e5c4818
Compare
tjzel
force-pushed
the
@tjzel/worklets/move-message-queue-to-worklets
branch
from
8dfb958 to
e52ddc9
Compare
tjzel
changed the base branch from
@tjzel/worklets/move-shareables-to-worklets
to
main
tjzel
added
the
Check compatibility
piaskowyk
requested changes
Nov 22, 2024
packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.cpp
Show resolved
Hide resolved
piaskowyk
approved these changes
Nov 25, 2024
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Moving `MessageQueueThread` to Worklets. It still has the name `REAMessageThread` or similar in some places. This will be addressed in the following PR. ## Test plan - [x] iOS 0.76 paper/fabric - [x] android 0.76 paper/fabric CI does the rest.
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Moving `MessageQueueThread` to Worklets. It still has the name `REAMessageThread` or similar in some places. This will be addressed in the following PR. ## Test plan - [x] iOS 0.76 paper/fabric - [x] android 0.76 paper/fabric CI does the rest.
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Moving `MessageQueueThread` to Worklets. It still has the name `REAMessageThread` or similar in some places. This will be addressed in the following PR. ## Test plan - [x] iOS 0.76 paper/fabric - [x] android 0.76 paper/fabric CI does the rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving
MessageQueueThreadto Worklets. It still has the nameREAMessageThreador similar in some places. This will be addressed in the following PR.Test plan
CI does the rest.