Skip to content

Commit

Permalink
fix(iOS): bad parameter type in toggleCancelButton search bar comma…
Browse files Browse the repository at this point in the history
…nd (#1854)

## Description

Fixes #1853

Looks like I've made a typo while implemnenting
`toggleCancelButton:flag:` (flag has `BOOL *` type instead of just
`BOOL`) leading to compile errors as reported in #1853.

## Changes

Changed (fixed) the type of `flag` parameter from `BOOL *` to just plain
`BOOL`.


## Test code and steps to reproduce

See #1853 & try to build on macOS Catalyst

## Checklist

- [ ] Ensured that CI passes
  • Loading branch information
kkafar authored Aug 2, 2023
1 parent a60dcaf commit 0844c85
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ios/RNSSearchBar.mm
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ - (UIView *)view
}];
}

RCT_EXPORT_METHOD(toggleCancelButton : (NSNumber *_Nonnull)reactTag flag : (BOOL *)flag)
RCT_EXPORT_METHOD(toggleCancelButton : (NSNumber *_Nonnull)reactTag flag : (BOOL)flag)
{
[self.bridge.uiManager addUIBlock:^(__unused RCTUIManager *uiManager, NSDictionary *viewRegistry) {
RNSSearchBar *searchBar = viewRegistry[reactTag];
Expand Down

0 comments on commit 0844c85

Please sign in to comment.