Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add
hideKeyboardOnSwipe
prop for Fabric (3) (#1433)
* chore: move hideKeyboardOnSwipe prop to common section in RNSScreen header * chore: add hideKeyboardOnSwipe prop to codegen * chore: make keyboard dismiss logic common * chore: add hideKeyboardOnSwipe prop update for Fabric * chore: add noop for Android This prop is marked as iOS only * chore: add `customAnimationOnSwipe` prop for Fabric (4) (#1434) * chore: add customAnimationOnSwipe prop to codegen * chore: move customAnimationOnSwipe prop to shared section in RNSScreen interface * refact: linter suggestion * chore: add customAnimationOnSwipe update for Fabric * chore: unify RNSScreenStackAnimator#animateTransition method This is possible as customAnimationOnSwipe prop is now implemented on Fabric * chore: unify RNSScreenStack#gestureRecognizer should begin method This is possible as customAnimationOnSwipe prop in now implemented on Fabric * chore: noop for Android This prop is annotated as iOS only in docs * chore: remove not needed difference between implementations * chore: add `gestureResponseDistance` prop for Fabric (5) (#1442) * chore: move gestureResponseDistance prop to shared section in RNSScreen interface * refact: linter suggestions * chore: add gestureResponseDistanceProp to Codegen * chore: add conversion methods for GestureResponseDistanceStruct * refact: linter suggestion * chore: add props update for Fabric As there is no way for creating custom `equality operator` for custom struct via codegen && such check (newProps != oldProps) would require three "ands" I think it is easier and potentially cheaper to just assign this (w/o surrounding if-check) * chore: unify RNSScreenStack#gestureRecognizerShouldBegin method * chore: move RNSScreenStackView#isInGestureResponseDistance:gestureRecognizer: method to common section This is now possible, as `gestureResponseDistance` prop is available on Fabric * chore: add noop for Android This prop is annotated as iOS only in docs * chore: change GestureResponseDistance field type from int to float * fix: merge artifact * chore: add deafult value for gestureResponseDistance on JS side It is still to be checked whether it is only place where this should be added * chore: unify RNSScreenStack#isInGestureResponseDistance:topScreen: method * chore: add `homeIndicatorHidden` & `activityState` props for Fabric (6) (#1443) * chore: add homeIndicatorHidden prop to codegen * chore: add prop update on Fabric * chore: add noop for Android This prop is iOS only * chore: move `activityState` prop to common section in RNSScreen interface * chore: move activityState setter to common section in RNSScreenView impl * refact: linter suggestion * chore: make RNSScreenView#reactSuperview common & make it implement RNSScreenContainerDelegate protocol This hasn't been tested yet. However in any instance it crashes (as the protocol might be not implemented) we can just implement noops for Fabric * chore: move activityState to implemented section in codegen config files * chore: make series of methods shared (see details) * `RNSScreenView#notifyFinishTransitioning` * `RNSScreen#notifyFinishTransitioning` * `willMoveToParentViewController` * `RNSScreenContainer#updateContainer` These methods were coupled together. * fix: handle activityState on Fabric Default value for the prop (when it is not set) on Fabric is -1 instead of nil (I believe we can not get nil from C++) thus this improved condition should work for both archs. * chore: add `preventNativeDismiss` prop for Fabric (7) (#1444) * chore: move preventNativeDismiss prop to common section in RNSScreen interface * fix: merge artifact * chore: add preventNativeDismiss prop to codegen * chore: add preventNativeDismiss prop update * fix: add noop for Android * chore: unify business logic between archs (8) (#1446) * chore: unify RNSScreen#vieDidLayoutSubviews * chore: make RNSScreenStack#hitTest:withEvent: method shared #1416 (comment) * chore: make RNSScreenStackView#isScrollViewPanGestureRecongnizer & some helper methods shared #1416 (comment) * chore: move backButtonInCustomView to shared sectionin RNSScreenStackHeaderConfig.h * chore: move backButtonInCustomView prop to implemented section in JS * chore: update `backButtonInCustomView` for Fabric * chore: unify RNSScreenStackHeaderConfigView#willShowViewController:animated:withConfig * refact: linter suggestion * fix: RNSScreen viewDidLayoutSubviews * chore: copy interfaces to android/src/paper directory * fix: commit address in comment It changed after I rebased
- Loading branch information