Skip to content

Commit

Permalink
chore: add changes from comments
Browse files Browse the repository at this point in the history
  • Loading branch information
maciekstosio committed May 22, 2024
1 parent 8b43fcd commit 3472960
Showing 1 changed file with 8 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ class SearchBarManager : ViewGroupManager<SearchBarView>(), RNSSearchBarManagerI
}

@ReactProp(name = "disableBackButtonOverride")
override fun setDisableBackButtonOverride(view: SearchBarView, value: Boolean) {
view.shouldOverrideBackButton = value != true
override fun setDisableBackButtonOverride(view: SearchBarView, disableBackButtonOverride: Boolean) {
view.shouldOverrideBackButton = disableBackButtonOverride != true
}

@ReactProp(name = "inputType")
Expand Down Expand Up @@ -106,12 +106,10 @@ class SearchBarManager : ViewGroupManager<SearchBarView>(), RNSSearchBarManagerI
}

@ReactProp(name = "shouldShowHintSearchIcon")
override fun setShouldShowHintSearchIcon(view: SearchBarView, value: Boolean) {
view.shouldShowHintSearchIcon = value ?: true
override fun setShouldShowHintSearchIcon(view: SearchBarView, shouldShowHintSearchIcon: Boolean) {
view.shouldShowHintSearchIcon = shouldShowHintSearchIcon ?: true
}

override fun setPlacement(view: SearchBarView, placeholder: String?) = Unit

override fun getExportedCustomDirectEventTypeConstants(): Map<String, Any>? {
return MapBuilder.of(
SearchBarBlurEvent.EVENT_NAME,
Expand Down Expand Up @@ -165,6 +163,10 @@ class SearchBarManager : ViewGroupManager<SearchBarView>(), RNSSearchBarManagerI

// iOS only

override fun setPlacement(view: SearchBarView, placeholder: String?) {
logNotAvailable("setPlacement")
}

override fun setHideWhenScrolling(view: SearchBarView?, value: Boolean) {
logNotAvailable("hideWhenScrolling")
}
Expand Down

0 comments on commit 3472960

Please sign in to comment.