Skip to content

Commit

Permalink
fix(Android): fix warning by removing package declaration from Androi…
Browse files Browse the repository at this point in the history
…dManifest (#2603)

## Description

See the discussion:


#2597 (comment)

## Changes

Removed the package declaration from Android Manifest.

## Test code and steps to reproduce

Passing build should be enough.

## Checklist

- [x] Ensured that CI passes
  • Loading branch information
kkafar authored Jan 8, 2025
1 parent bc24731 commit fbc9a00
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 2 additions & 1 deletion android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,10 @@ def IS_NEW_ARCHITECTURE_ENABLED = isNewArchitectureEnabled()

android {
compileSdkVersion safeExtGet('compileSdkVersion', rnsDefaultCompileSdkVersion)
namespace "com.swmansion.rnscreens"

def agpVersion = Version.ANDROID_GRADLE_PLUGIN_VERSION
if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
namespace "com.swmansion.rnscreens"
buildFeatures {
buildConfig true
}
Expand Down
3 changes: 1 addition & 2 deletions android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.swmansion.rnscreens">
<manifest xmlns:android="http://schemas.android.com/apk/res/android">

</manifest>

0 comments on commit fbc9a00

Please sign in to comment.