Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][bug] - RNS 3.11.0 has broken fullScreenGestureEnabled #1312

Closed
3 of 7 tasks
hirbod opened this issue Feb 11, 2022 · 6 comments · Fixed by #1313
Closed
3 of 7 tasks

[iOS][bug] - RNS 3.11.0 has broken fullScreenGestureEnabled #1312

hirbod opened this issue Feb 11, 2022 · 6 comments · Fixed by #1313
Labels
Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS

Comments

@hirbod
Copy link
Contributor

hirbod commented Feb 11, 2022

Description

I've just upgraded to 3.11.0 and I can't swipe anymore with fullScreenSwipe. It looks like it has a 10x friction and even if I swipe the whole screen, it just move by 5px and snaps back

Screenshots

Steps To Reproduce

  1. Update to 3.11.0 and you won't be able to close any screen with fullScreenGestureEnabled

Expected behavior

Should be able to swipe to pop

Actual behavior

Can't swipe to pop anymore

Reproduction

Just upgrade to 3.11.0 and try to swipe with fullScreen without setting any durations etc.
Video: https://streamable.com/wsdztc

      <RouterMainStack.Screen
        name="Blocker"
        component={Blocker}
        options={{
          fullScreenGestureEnabled: true,
        }}
      />

Platform

  • iOS
  • Android
  • Web
  • Windows
  • tvOS

Workflow

  • Managed workflow
  • Bare workflow

Package versions

package version
react-native 0.64.3
@react-navigation/native 6.0.8
@react-navigation/native-stack 6.5.0
react-native-screens 3.11.0
react-native-safe-area-context 3.3.2
react-native-gesture-handler 2.1.1
react-native-reanimated 2.4.1
expo SDK 44 custom dev client
@github-actions github-actions bot added Platform: iOS This issue is specific to iOS Missing repro This issue need minimum repro scenario labels Feb 11, 2022
@github-actions
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snippet of code, a snack or a link to a GitHub repository that reproduces the problem?

@hirbod
Copy link
Contributor Author

hirbod commented Feb 11, 2022

Oh, lol. It is actually closing when I swipe from top to bottom, but not from left to right.
Guess this PR is the reason:

f2ac36b

I am not using swipeDirection "vertical" anywhere.

@hirbod
Copy link
Contributor Author

hirbod commented Feb 11, 2022

Here is a video, demonstrating the issue: 3.10.2 is working without issues.
https://streamable.com/wsdztc

kacperkapusciak added a commit that referenced this issue Feb 11, 2022
This PR sets RNSScreenSwipeDirectionHorizontal as the first property on RNSScreenSwipeDirection enum. Effectively that sets swipeDirection to horizontal in the Obj-C part of the library.

Fixes #1312
@kacperkapusciak
Copy link
Member

Brrr, nasty bug 😓

Fixed in 3.11.1 :shipit:

@hirbod
Copy link
Contributor Author

hirbod commented Feb 11, 2022

Thank you!

@hirbod
Copy link
Contributor Author

hirbod commented Feb 11, 2022

I can confirm it's fixed. Only the new props are missing on react-navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants