-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS][bug] - RNS 3.11.0 has broken fullScreenGestureEnabled #1312
Comments
Hey! 👋 The issue doesn't seem to contain a minimal reproduction. Could you provide a snippet of code, a snack or a link to a GitHub repository that reproduces the problem? |
Oh, lol. It is actually closing when I swipe from top to bottom, but not from left to right. I am not using swipeDirection "vertical" anywhere. |
Here is a video, demonstrating the issue: 3.10.2 is working without issues. |
This PR sets RNSScreenSwipeDirectionHorizontal as the first property on RNSScreenSwipeDirection enum. Effectively that sets swipeDirection to horizontal in the Obj-C part of the library. Fixes #1312
Brrr, nasty bug 😓 Fixed in 3.11.1 |
Thank you! |
I can confirm it's fixed. Only the new props are missing on react-navigation |
Description
I've just upgraded to 3.11.0 and I can't swipe anymore with fullScreenSwipe. It looks like it has a 10x friction and even if I swipe the whole screen, it just move by 5px and snaps back
Screenshots
Steps To Reproduce
Expected behavior
Should be able to swipe to pop
Actual behavior
Can't swipe to pop anymore
Reproduction
Just upgrade to 3.11.0 and try to swipe with fullScreen without setting any durations etc.
Video: https://streamable.com/wsdztc
Platform
Workflow
Package versions
The text was updated successfully, but these errors were encountered: