Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash using FullWindowOverlay #1374

Closed
2 of 7 tasks
hukpo opened this issue Mar 26, 2022 · 4 comments · Fixed by #1375
Closed
2 of 7 tasks

Crash using FullWindowOverlay #1374

hukpo opened this issue Mar 26, 2022 · 4 comments · Fixed by #1375
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided

Comments

@hukpo
Copy link

hukpo commented Mar 26, 2022

Description

I'm experiencing a crash using FullWindowOverlay with navigation.goBack()
The problem is here because _container is nil:

[_touchHandler detachFromView:_container];

The reason it's nil is because didMoveToWindow was called 2 times

- (void)didMoveToWindow

Screenshots

image

Steps To Reproduce

  1. Open screen with FullWindowOverlay
  2. Go back using navigation.goBack()

Expected behavior

No crash

Actual behavior

Crash

Reproduction

https://github.com/hukpo/rncrash

Platform

  • iOS
  • Android
  • Web
  • Windows
  • tvOS

Workflow

  • Managed workflow
  • Bare workflow

Package versions

package version
react-native 0.67.4
@react-navigation/native ^6.0.8
@react-navigation/native-stack ^6.5.2
react-native-screens ^3.13.1
react-native-safe-area-context ^4.2.2
@github-actions github-actions bot added Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided labels Mar 26, 2022
@WoLewicki
Copy link
Member

Can you check if #1375 fixes your issue and does not introduce any new ones?

@hukpo
Copy link
Author

hukpo commented Mar 28, 2022

@WoLewicki Thanks, it works well

@dancixx
Copy link

dancixx commented Jun 2, 2022

It is still happening.

react-native: 0.67.4
react-native-screens: latest

@WoLewicki
Copy link
Member

@dancixx please provide a repository where it can be easily reproduced so we can work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: iOS This issue is specific to iOS Repro provided A reproduction with a snack or repo is provided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants