Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add check for if container is null #1375

Merged
merged 1 commit into from
Mar 28, 2022
Merged

fix: add check for if container is null #1375

merged 1 commit into from
Mar 28, 2022

Conversation

WoLewicki
Copy link
Member

Description

Added check for if _container is nil which leads to app crash if invalidate was called before didMoveToWindow (e.g. navigating back from screen with navigation.goBack()). Should fix #1374.

Test code and steps to reproduce

Example from #1374

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@WoLewicki WoLewicki mentioned this pull request Mar 28, 2022
Closed
7 tasks
@WoLewicki WoLewicki merged commit a12e257 into main Mar 28, 2022
@WoLewicki WoLewicki deleted the @wolewicki/fix-overlay-crash branch March 28, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash using FullWindowOverlay
1 participant
@WoLewicki