Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.72 RN app not installed on IOS, parse and sematic issues. #1859

Closed
arbuzaicer opened this issue Aug 3, 2023 · 9 comments · Fixed by #1860
Closed

0.72 RN app not installed on IOS, parse and sematic issues. #1859

arbuzaicer opened this issue Aug 3, 2023 · 9 comments · Fixed by #1860
Assignees
@kkafar
Labels
Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS

Comments

@arbuzaicer
Copy link

Description

RNScreens is crashing during installation for IOS platform with 6 issues.

Most of the issues are located in RNSearchBar.h, RNSearchBar.mm files.

Знімок екрана 2023-08-03 о 8 15 20 пп Знімок екрана 2023-08-03 о 8 16 36 пп Знімок екрана 2023-08-03 о 8 16 53 пп Знімок екрана 2023-08-03 о 8 17 06 пп

Steps to reproduce

  1. install latest RN project npx react-native@latest init AwesomeProject
  2. install rnscreens yarn add react-native-screens
  3. Try to install the app for IOS through xCode.

Snack or a link to a repository

https://github.com/

Screens version

3.23.0

React Native version

0.72.3

Platforms

iOS

JavaScript runtime

None

Workflow

React Native (without Expo)

Architecture

Fabric (New Architecture)

Build type

None

Device

iOS simulator

Device model

No response

Acknowledgements

Yes
@github-actions github-actions bot added the Missing repro This issue need minimum repro scenario label Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added the Platform: iOS This issue is specific to iOS label Aug 3, 2023
@kkafar
Copy link
Member

kkafar commented Aug 3, 2023

Hey @arbuzaicer, what version of iOS are you deploying for and what version of XCode do you use?

@SamiChab
Copy link

SamiChab commented Aug 3, 2023

Same for me ! Deploying for iOS 12.4 with XCode 13.2.1

@kkafar kkafar self-assigned this Aug 3, 2023
@kkafar kkafar mentioned this issue Aug 3, 2023
Merged
1 task
@kkafar
Copy link
Member

kkafar commented Aug 3, 2023

Thanks @SamiChab,

I've broken this in #1843 by forgetting to add iOS API availability checks around method definitions and didn't spot the issue because I have newest SDK installed.

I've prepared the fix, will try to release minor version tomorrow.

@SamiChab
Copy link

SamiChab commented Aug 3, 2023

Thank you @kkafar ✨

@kkafar
Copy link
Member

kkafar commented Aug 4, 2023 •
edited
Loading

Can please anyone affected confirm that fix in #1860 works? I have no disk space left to download & test older SDK 🙈

You can check it out by installing react-native-screens directly from the branch in package.json:

"react-native-screens": "software-mansion/react-native-screens#@kkafar/build-problems-ios-16"

(clear cache & rebuild native code).

cc @SamiChab, @levanthuanmy, @arbuzaicer

@arbuzaicer
Copy link
Author

Thx 🙏 @kkafar

kkafar added a commit that referenced this issue Aug 4, 2023
@kkafar
fix(iOS): add missing iOS API availbility checks (#1860)
4694525 
## Description

When adding 

#1843

I've forgotten to add API avaibility checks for method definitions
(usage and declarations were guarded). This caused build problems when
deploying for lower iOS versions.

Fixes #1859

## Changes

Added missing availbility checks.

## Test code and steps to reproduce

Build iOS without having iOS 16 installed (or somehow disabled?).

## Checklist

- [x] Ensured that CI passes
@kkafar
Copy link
Member

kkafar commented Aug 4, 2023

I've released 3.24.0 with fix #1860, should be available to download straight from npm.

@arbuzaicer
Copy link
Author

@kkafar successfully updated and installed. All good. thanks for the quick reaction :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkafar kkafar

Labels
Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(iOS): add missing iOS API availbility checks software-mansion/react-native-screens
3 participants
@SamiChab @arbuzaicer @kkafar