Not able to navigate to a nested modal navigator #2085
Comments
github-actions
bot
added
the
Missing repro
|
Hey! 👋 The issue doesn't seem to contain a minimal reproduction. Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem? |
|
Do you know why you added the react-native-screens/ios/RNSScreenStack.mm Line 390 in 471127e Can you please explain it? It seems to cause an issue with accessing the I'm trying to reproduce it using the example project, but have some trouble with running the example project. #2086 |
|
@kkafar When do you plan to create a new release? |
|
Only thing holding me back is to allocate a time for library testing before releasing a version (and actually we have slight problem on main rn, but it should be fixed today). I would say you can expect one early next week, but this is a rough estimate. |
|
@kkafar how are you doing? I don't want to ask you again but please don't forget ;-) |
…mansion#2113) ## Description Basically this is another edition of the issue software-mansion#1829 (handled by software-mansion#1912). The issue comes down to the fact, that our `ScreenStack` is not aware of all modal view controllers being in presentation, but this time it is not aware of third-party modal view controllers (I've named them "foreign" modals in opposite to "owned" modals). This PR is not a comprehensive solution but rather just a patch aiming at fixing one particular interaction reported in software-mansion#2048. I've left verbose code comments explaining the issue and suggesting solution in the source code, including: ``` // TODO: Find general way to manage owned and foreign modal view controllers and refactor this code. Consider building // model first (data structue, attempting to be aware of all modals in presentation and some text-like algorithm for // computing required operations). ``` Closes software-mansion#2048 Closes software-mansion#2085 ## Changes Trigger dissmisal of foreign modal if it is presented above `changeRoot` modal (last modal that is to stay on stack after the updates). ## Test code and steps to reproduce `Test2048` in `TestsExample` & `FabricTestExample`. ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes
Description
When trying to open a nested modal, the screen isn't opening. After some research this is due to the
__blockkeyword.This seems to be wrongly fixed in this PR: 471127e
Changing the following line will fix the issue:
into
Steps to reproduce
Snack or a link to a repository
not-needed
Screens version
3.30.1
React Native version
0.72.x
Platforms
iOS
Acknowledgements
Yes
The text was updated successfully, but these errors were encountered: