feat: expose new container for 2-state navigators #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2021
This was
linked to
issues
Jul 28, 2021
satya164
reviewed
Jul 29, 2021
src/types.tsx
Outdated
| /** | ||
| * A prop to be used in drawer and bottom-tabs navigators for better implementation of ScreenContainer on iOS. | ||
| */ | ||
| tabsOrDrawer?: boolean; |
There was a problem hiding this comment.
I think a prop name like hasTwoStates (didn't think a lot about the name) or something like that would be more generic and more appropriate
src/index.native.tsx
Outdated
| @@ -47,6 +47,8 @@ function enableScreens(shouldEnableScreens = true): void { | |||
|
|
|||
| // const that tells if the library should use new implementation, will be undefined for older versions | |||
| const shouldUseActivityState = true; | |||
| const isNavigationContainerAvailable = | |||
There was a problem hiding this comment.
Is there a case when this won't be available when someone is using this version of react-native-screens?
There was a problem hiding this comment.
What if someone updates to this version of library in Expo managed workflow? I know it should not be done, but 🤷♂️ .
There was a problem hiding this comment.
@WoLewicki updating to an incompatible version of the library could also cause other issues as well, and surface bugs which are already fixed in latest version, so probably not a use case we should support.
WoLewicki
changed the title
2 tasks
…methods from header
kacperkapusciak
approved these changes
Sep 6, 2021
satya164
pushed a commit
to react-navigation/react-navigation
that referenced
this pull request
Feb 1, 2022
Added new prop `tabsOrDrawer` for `ScreenContainer` which makes `react-native-screens` on `iOS` use new component if it is available. See software-mansion/react-native-screens#1029 for context.
darkhorse-coder
pushed a commit
to darkhorse-coder/react-navigation
that referenced
this pull request
Apr 7, 2022
Added new prop `tabsOrDrawer` for `ScreenContainer` which makes `react-native-screens` on `iOS` use new component if it is available. See software-mansion/react-native-screens#1029 for context.
nenad0212
pushed a commit
to nenad0212/temp1
that referenced
this pull request
Sep 6, 2022
Added new prop `tabsOrDrawer` for `ScreenContainer` which makes `react-native-screens` on `iOS` use new component if it is available. See software-mansion/react-native-screens#1029 for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adding
RNSScreenNavigationContainercomponent on iOS. This component should be used inbottom-tabsanddrawernavigators ofreact-navigationin order to resolve layout issues connected to integration betweenUIViewControllerandUINavigationControllercontainers (see #619 and #564).stacknavigator unfortunately cannot useUINavigationControllersince it needs the previous screens to be visible e.g. during the transition. Connected PR inreact-navigation: react-navigation/react-navigation#9772Changes
Added new component and
hasTwoStatesprop forScreenContainerwhich controls which native component should be used.Test code and steps to reproduce
Test619.jsandTest564.jsto see the layout issues gone. It needs settinghasTwoStatesprops onbottom-tabsnavigator in order for this to work.Checklist