fix: downgrade kotlin & take kotlinVersion from ext #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperkapusciak
changed the title
|
When will this be merged? I am having an issue with the kotlin version mismatch because I've defined it in ext |
|
@RazaShehryar we could merge this change today but there probably won't be a new version of Cheers |
WoLewicki
approved these changes
Sep 21, 2021
kacperkapusciak
deleted the
@kacperkapusciak/fix-jar-runtime-classpath-version-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR downgrades kotlin version to match react-native's one - https://github.com/facebook/react-native/blob/main/ReactAndroid/src/main/third-party/kotlin/BUCK#L54
Adds a way for the developer to override kotlin version via
kotlinVersionprop inbuild.gradleextproperty.Also, removes the dependency on the standard library (explaination) thus lets Gradle infer correct versions for a particular Kotlin version.
Fixes #1109.
Test code and steps to reproduce
Run ./gradlew compileDebugKotlin in react-native-screens/TestsExample/android.
Checklist