Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adds screenshot artifact to iOS e2e #1139

Merged
merged 4 commits into from
Sep 21, 2021
Merged

chore: Adds screenshot artifact to iOS e2e #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae1b101
chore: Adds screenshot artifact to ios e2e
Sep 20, 2021
2017b61
chore: Adds screenshot to ios detox
Sep 20, 2021
11993d1
Merge branch 'master' into @ubax/add-e2e-ios-saving-screenshots
Sep 21, 2021
e515e11
chore: Change atrifact name to ios
Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ios-e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Test iOS e2e
on:
pull_request:
paths:
- 'Example/**'
- 'Example/**'
kacperkapusciak marked this conversation as resolved.
Show resolved Hide resolved
push:
branches:
- master
Expand Down Expand Up @@ -42,3 +42,8 @@ jobs:
- name: Test app
working-directory: ${{ env.WORKING_DIRECTORY }}
run: yarn test-e2e-ios
- uses: actions/upload-artifact@v2
if: ${{ failure() }}
with:
name: ios-fail-screen-shoots
path: ${{ env.WORKING_DIRECTORY }}/artifacts
2 changes: 1 addition & 1 deletion Example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"check-types": "tsc --noEmit",
"build-e2e-ios": "detox build --configuration ios.release",
"build-e2e-android": "detox build --configuration android.release",
"test-e2e-ios": "detox test --configuration ios.release",
"test-e2e-ios": "detox test --configuration ios.release --take-screenshots failing",
"test-e2e-android": "detox test --configuration android.release --take-screenshots failing"
},
"dependencies": {
Expand Down