Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove adding to back stack logic on Android #1148

Merged
merged 1 commit into from
Sep 23, 2021
Merged

feat: remove adding to back stack logic on Android #1148

merged 1 commit into from
Sep 23, 2021

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Sep 22, 2021 •
edited
Loading

Description

PR removing the behavior of attaching listener for backStack changes on Android. Based on https://stackoverflow.com/a/60560844/13006595 it looks like it is not available while using synchronous Fragment updates via commitNow. Also, it was not used in react-navigation since it provides its own listener for hardware back button on Android.

It can be considered BREAKING CHANGE if you use this library outside of react-navigation

Test code and steps to reproduce

All tests working even when gestureEnabled set to true on Android in NativeStackView.

Checklist

@WoLewicki WoLewicki linked an issue Sep 22, 2021 that may be closed by this pull request
ScreenStack throws fragment exception from pushing screen #1138
Closed
@WoLewicki WoLewicki mentioned this pull request Sep 22, 2021
Closed
@WoLewicki WoLewicki merged commit 5399172 into master Sep 23, 2021
@WoLewicki WoLewicki deleted the @wolewicki/remove-back-stack-subscription branch September 23, 2021 12:08
@tsvetann tsvetann mentioned this pull request Nov 8, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kacperkapusciak kacperkapusciak kacperkapusciak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScreenStack throws fragment exception from pushing screen
2 participants
@WoLewicki @kacperkapusciak