fix: canceled swipe gesture on iOS 12 when direction hasn't changed #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperkapusciak
changed the title
WoLewicki
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting up the default value for
directionin native stack v6 revealed an issue with a swipe gesture on iOS 12.Setting
directionwith the same value twice cancels the transition between screens in iOS 12.This issue doesn't occur on iOS 13+ because Apple reimplemented how the gesture system works.
Fixes #1091
Changes
directioninRNScreenStackHeaderConfigonly when it changedScreenshots / GIFs
Before
RPReplay_Final1632394072.MP4
After
RPReplay_Final1632401799.MP4
Test code and steps to reproduce
Test1091.tsxinTestsExampleprojectChecklist