Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove touch disabling in header corners #1157

Merged
merged 4 commits into from
Oct 5, 2021

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Sep 28, 2021

Description

PR fixing the behavior of cutting the hit area of the corners of the header when the headerLeft/headerRight components are provided. It overrides the default method and checks directly if the point is inside one of header subviews. Should fix #692.

Test code and steps to reproduce

Test1157.tsx

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WoLewicki WoLewicki merged commit 1ca4fff into master Oct 5, 2021
@WoLewicki WoLewicki deleted the @wolewicki/ios-header-insets branch October 5, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make header left/right insets configurable
2 participants