Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds search bar on Android #1166

Merged
merged 70 commits into from
Nov 12, 2021
Merged

feat: Adds search bar on Android #1166

merged 70 commits into from
Nov 12, 2021

Conversation

Ubax
Copy link
Contributor

@Ubax Ubax commented Oct 6, 2021 •
edited
Loading

@Ubax Ubax assigned WoLewicki and unassigned WoLewicki Oct 11, 2021
@Ubax Ubax requested a review from WoLewicki October 11, 2021 09:39
WoLewicki
WoLewicki reviewed Oct 11, 2021
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some observations about the code. Please answer them and keep up with the good work!

android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderSubview.kt Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarView.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarView.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarView.kt Show resolved Hide resolved
kacperkapusciak
kacperkapusciak reviewed Oct 11, 2021
View reviewed changes
src/types.tsx Outdated Show resolved Hide resolved
src/native-stack/views/HeaderConfig.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
src/native-stack/utils/searchBarPlatforms.tsx Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarView.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarView.kt Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarView.kt Outdated Show resolved Hide resolved
@Ubax
Copy link
Contributor Author

Ubax commented Oct 21, 2021

@kacperkapusciak I updated the docs. I think I did it in all necessary places

kacperkapusciak
kacperkapusciak approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts and fix an issue with disableBackButtonOverride prop. Other than that LGTM! 🙌 🚀

Also, please wait for @WoLewicki approval before merging

Cheers

WoLewicki
WoLewicki reviewed Oct 29, 2021
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I added some comments, please answer them and ping me after that.

TestsExample/src/Test1166/AndroidDifferentScreenSearch.tsx Outdated Show resolved Hide resolved
TestsExample/src/Test1166/AndroidSearchBarEvents.tsx Outdated Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/CustomSearchView.kt Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt Show resolved Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarView.kt Show resolved Hide resolved
src/types.tsx Outdated Show resolved Hide resolved
src/index.tsx Outdated Show resolved Hide resolved
src/native-stack/views/HeaderConfig.tsx Show resolved Hide resolved
src/native-stack/views/HeaderConfig.tsx Outdated Show resolved Hide resolved
src/native-stack/utils/useBackPressSubscription.tsx Show resolved Hide resolved
WoLewicki
WoLewicki reviewed Nov 2, 2021
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for answering the previous comments! I left some more and I think it is now OK to add v4 version too.

guides/GUIDE_FOR_LIBRARY_AUTHORS.md Outdated Show resolved Hide resolved
src/createNativeStackNavigator.tsx Outdated Show resolved Hide resolved
src/types.tsx Outdated Show resolved Hide resolved
src/native-stack/utils/useBackPressSubscription.tsx Outdated Show resolved Hide resolved
src/native-stack/utils/useBackPressSubscription.tsx Outdated Show resolved Hide resolved
@Ubax Ubax requested a review from WoLewicki November 3, 2021 12:13
WoLewicki
WoLewicki approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Please wait for @kacperkapusciak and we can merge it!

@Ubax Ubax merged commit eb9f2e0 into master Nov 12, 2021
@Ubax Ubax deleted the @ubax/android-searchbar branch November 12, 2021 10:46
@ChrisEdson ChrisEdson mentioned this pull request Dec 25, 2021
Closed
@leotm leotm mentioned this pull request Feb 3, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoLewicki WoLewicki WoLewicki approved these changes

@kacperkapusciak kacperkapusciak kacperkapusciak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ubax @WoLewicki @kacperkapusciak