feat: don't set display: 'none' on frozen screens #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Graham Mendick <graham.mendick@gmail.com>
WoLewicki
approved these changes
Nov 10, 2021
kacperkapusciak
deleted the
@kacperkapusciak/dont-set-display-none-on-frozen-screens
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Suspensemechanism inreact-freezesetsdisplay: noneon a frozen screen. This sometimes results in an 'empty' screen when navigating between multiple screens at once (e.g. by using iOS back button menu).This PR prevents showing frozen screen by making the
displayproperty onviewConfig.validAttributes.stylenot valid.A detailed explanation can be found here
Thank you @grahammendick for this brilliant idea! 🙌
Fixes #1207
Test code and steps to reproduce
Test658,Test791,TestFreezeinTestsExample/projectChecklist