Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if topScreen is RNSScreenView #1224

Merged
merged 1 commit into from
Dec 2, 2021
Merged

fix: check if topScreen is RNSScreenView #1224

merged 1 commit into from
Dec 2, 2021

Conversation

WoLewicki
Copy link
Member

Description

Added a check for if topScreen in gestureRecognizerShouldBegin method is RNSScreenView, since it is not in some cases. Reproduction of such behavior would be much needed. Should fix #1194.

Test code and steps to reproduce

Not yet available

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@WoLewicki WoLewicki mentioned this pull request Nov 30, 2021
Closed
7 tasks
kacperkapusciak
kacperkapusciak approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to break anything swipe gesture-related and potentially could fix a crash.

@WoLewicki WoLewicki merged commit 1548db4 into master Dec 2, 2021
@WoLewicki WoLewicki deleted the @wolewicki/fix-topscreen-not-screenview branch December 2, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kacperkapusciak kacperkapusciak kacperkapusciak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@WoLewicki @kacperkapusciak