Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update search bar playground in Example app #1226

Merged

Conversation

kacperkapusciak
Copy link
Member

Description

Update Example app to reflect current master status.

The search bar is now available also on Android devices and thus 'Search bar' section needed to be updated.

Not every available search bar setting was reflected in the Example.

Changes

  • Updated Search bar example
  • Reverted search bar documentation for react-navigation v4

Screenshots

Screenshot_1638453841

Screenshot_1638453853

Test code and steps to reproduce

Search Bar playground in Example/ project

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

Copy link
Contributor

@Ubax Ubax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kacperkapusciak kacperkapusciak merged commit 76f4fc6 into master Dec 3, 2021
@kacperkapusciak kacperkapusciak deleted the @kacperkapusciak/add-android-searchbar-to-example branch December 3, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants