Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use shouldUseOpenAnimation to determine animation #1227

Merged
merged 2 commits into from
Dec 2, 2021
Merged

fix: use shouldUseOpenAnimation to determine animation #1227

merged 2 commits into from
Dec 2, 2021

Conversation

kacperkapusciak
Copy link
Member

@kacperkapusciak kacperkapusciak commented Dec 2, 2021 •
edited
Loading

Description

#1190 introduced a bug where stack animation was incorrectly resolved on Android during simple navigate.

Thanks to @WoLewicki for creating the fix

Test code and steps to reproduce

Test1227.tsx

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@kacperkapusciak kacperkapusciak merged commit c74043c into master Dec 2, 2021
@kacperkapusciak kacperkapusciak deleted the kacperkapusciak/fix-open-animation-on-android branch December 2, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoLewicki WoLewicki WoLewicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kacperkapusciak @WoLewicki