feat(android): Add new properties to search view #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubax
suggested changes
Jan 4, 2022
android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchViewFormatter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchViewFormatter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchViewFormatter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchViewFormatter.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt
Outdated
Show resolved
Hide resolved
Ubax
reviewed
Jan 5, 2022
|
For e2e ios testing, it appear that it doesn't link to my PR, but it failed with BottomTabsAndStack EDIT: I ran it on my computer and all the tests passed. |
Ubax
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add three new properties for android search view (headerIconColor, textHintColor, hintSearchIcon)
Changes
createNativeStackNavigator/README.mddocsguides/GUIDE_FOR_LIBRARY_AUTHORS.mddocsnative-stack/README.mddocssrc/types.tsxdocsScreenshots / GIFs
After
Test code and steps to reproduce
You can run the exemple project and change the search view properties in android only sections
Checklist