Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add transition duration on iOS #1259

Merged
merged 10 commits into from
Feb 7, 2022

Conversation

WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Jan 5, 2022

Description

Added transition duration on iOS requested in #1171.

The prop changes the duration of slide_from_bottom, fade_from_bottom, fade and simple_push transitions on iOS. The duration of default and flip transitions isn't customizable.

Such prop could be also added on Android, but each of fragments have its own transition duration, so the way it should be applied would need to be thought over. One of options is to set the duration of currently added or currently removed fragment on both of them.

Test code and steps to reproduce

Test1259.tsx in TestsExample/ project

Checklist

Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kacperkapusciak kacperkapusciak merged commit e27baec into main Feb 7, 2022
@kacperkapusciak kacperkapusciak deleted the @wolewicki/ios-transition-duration branch February 7, 2022 14:22
@d-moreira
Copy link

Hi @WoLewicki,

are there any plans to add support for transition duration on Android in the near future?

@hirbod
Copy link
Contributor

hirbod commented Feb 10, 2022

Could you guys also push the new props to react-navigation please? ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants