-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add transition duration on iOS #1259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Feb 7, 2022
tomekzaw
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
kacperkapusciak
approved these changes
Feb 7, 2022
Hi @WoLewicki, are there any plans to add support for transition duration on Android in the near future? |
Could you guys also push the new props to react-navigation please? ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added transition duration on iOS requested in #1171.
The prop changes the duration of
slide_from_bottom
,fade_from_bottom
,fade
andsimple_push
transitions on iOS. The duration ofdefault
andflip
transitions isn't customizable.Such prop could be also added on
Android
, but each of fragments have its own transition duration, so the way it should be applied would need to be thought over. One of options is to set the duration of currently added or currently removed fragment on both of them.Test code and steps to reproduce
Test1259.tsx
inTestsExample/
projectChecklist