feat: Publish fabric and classic architecture release #1308
Conversation
| fontWeight: '700', | ||
| }, | ||
| }); | ||
| import {createNativeStackNavigator} from '@react-navigation/native-stack'; |
There was a problem hiding this comment.
Wouldn't it be better to use v5 version of native-stack since it will get all the files straight from our repo? If not, could you check if we files imported from react-native-screens inside @react-navigation/native-stack are taken from our repo and not as some other version in its node_modules?
| const styles = StyleSheet.create({ | ||
| container: { | ||
| flex: 1, | ||
| paddingTop: Platform.OS === 'ios' ? 30 : 100, |
There was a problem hiding this comment.
Why is this padding needed? So the options are visible when the header is translucent? Shouldn't it be managed by system?
There was a problem hiding this comment.
It is not managed by system if we have translucent off and header on
There was a problem hiding this comment.
But then the content should be just below the header and the padding shouldn't be needed, am I right?
There was a problem hiding this comment.
What I wanted to write is we have translucent on and header on
In this scenario the content will "hide" below the header
There was a problem hiding this comment.
With ScrollView on iOS, the content should move itself to the correct position. On Android, it may be different though.
| #if defined(__IPHONE_OS_VERSION_MAX_ALLOWED) && defined(__IPHONE_13_0) && \ | ||
| __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_13_0 | ||
| if (@available(iOS 13.0, *)) { | ||
| // font customized on the navigation item level, so nothing to do here | ||
| } else | ||
| #endif | ||
| { |
| @@ -91,8 +105,9 @@ let NativeFullWindowOverlay: React.ComponentType<View>; | |||
|
|
|||
| const ScreensNativeModules = { | |||
| get NativeScreen() { | |||
| NativeScreenValue = | |||
| NativeScreenValue || requireNativeComponent('RNSScreen'); | |||
| const nativeComponent = () => | |||
There was a problem hiding this comment.
Is there a reason this code is wrapped in a function?
There was a problem hiding this comment.
So that it is not executed twice
There was a problem hiding this comment.
So shouldn't we do it in current implementation too?
Ubax
force-pushed
the
@ubax/publish-fabric-classic
branch
from
08e5864
to
eb3d555
Compare
## Description <!-- Description and motivation for this PR. Include Fixes #<number> if this is fixing some issue. Fixes # . --> Add missing `ScreenStackHeaderConfig` events to fabric spec and remove the manual registration of events. Also changed `Bubbling` events to `Direct` which fixes extraneous lifecycle events. It was to be done quite a while ago already: #1308 (comment)
## Description <!-- Description and motivation for this PR. Include Fixes #<number> if this is fixing some issue. Fixes # . --> Add missing `ScreenStackHeaderConfig` events to fabric spec and remove the manual registration of events. Also changed `Bubbling` events to `Direct` which fixes extraneous lifecycle events. It was to be done quite a while ago already: software-mansion#1308 (comment)
Description
Checklist