Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: headerTitle & title props on Fabric #1320

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

kacperkapusciak
Copy link
Member

Description

This PR fixes compilation on iOS and behavior of headerTitle and title props on Fabric.

Test code and steps to reproduce

FabricExample/ project

Checklist

  • Ensured that CI passes

@kacperkapusciak kacperkapusciak changed the title fix: headerTitle & title props fix: headerTitle & title props on Fabric Feb 15, 2022
Copy link
Contributor

@Ubax Ubax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀
Thanks for fixing it

@kacperkapusciak kacperkapusciak merged commit 36c7db5 into main Feb 16, 2022
@kacperkapusciak kacperkapusciak deleted the @kacperkapusciak/fix-headerTitle-prop branch February 16, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants