fix: blurView integration with ScreenStack #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
mjm918
pushed a commit
to mjm918/RNScreensBlurViewCrash-Repro
that referenced
this pull request
Apr 14, 2022
software-mansion/react-native-screens#1406 ● App will not crash if there is single blurview ● In first screen there is 1 blurview and the app did not crash ● In second screen there are multiple blurview and app crashed with exception `java.lang.IndexOutOfBoundsException: Index: 1, Size: 0` ● As suggested, I added `android:hardwareAccelerated="true"` in Manifest but the crash still persist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BlurViewsometimes callsdrawmethod of the app's rootView, causing unexpected behavior in our library. SinceBlurViewis a child ofScreenStackin the crashing example, callingop.draw()callsBlurViewonDrawmethod, which then sometimes callsdrawmethod in app'srootView. It results in visiting thedrawAndReleasemethod again. The important thing isdrawingOps.indicesmakesIntRangeunder the hood, which is then used in next loop calls. At the same time, after the most nestedforloop ends, it clears thedrawingOps, but this change is not visible in the formerforsince it just loops overIntRangecreated before. This results inindexOutOfBoundscrash when we try to obtain anopfrom emptydrawingOps. As an addition, If we didn't useindices, butfor (op in drawingOps), it would result inConcurrentModificationException.Current fix makes a copy of
drawingOpswhich is then used inforloop, and clearing thedrawingOpsso the nested calls cannot change the original one.Test code and steps to reproduce
https://github.com/mjm918/RNScreensBlurViewCrash-Repro/blob/master/AppCrash.tsx
Checklist