Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: merge Fabric & Paper impls: ScreenStackHeaderConfig (3) #1417

Merged
merged 137 commits into from
Apr 28, 2022
Merged

refact: merge Fabric & Paper impls: ScreenStackHeaderConfig (3) #1417

merged 137 commits into from
Apr 28, 2022

Commits on Apr 8, 2022

  1. chore: Set RN_FABRIC_ENABLED compiler flag when fabric is enabled

    @kkafar
    kkafar committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    6f2121a View commit details
    Browse the repository at this point in the history

  2. refract: Move RNSScreenComponentView implementation to RNSScreenView && 

    RNSScreenController to RNSScreen
    @kkafar
    kkafar committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    00fc6db View commit details
    Browse the repository at this point in the history

  3. refract: Rename dependencies to make previous change work

    @kkafar
    kkafar committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    6dd5347 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. chore: update Cocoapods to .3

    @kkafar
    kkafar committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    9f78cc0 View commit details
    Browse the repository at this point in the history

  2. fix: type in RNSScreen.mm

    @kkafar
    kkafar committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    9b18375 View commit details
    Browse the repository at this point in the history

  3. fix: add missing space to compiler flags in RNScreens.podspec 

    It caused RN_FABRIC_ENABLED flag to be invalid (as it merged with
    previous flag from the list...)
    @kkafar
    kkafar committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    4a1c315 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. refact: rename all source .m files to .mm 

    Otherwise C++ standard headers are not visible from .m files -> project
fails to build.

e.g. Whem=n A.m includes B.h & B.h imports memory header: "#include
<memory>" -- memory header is not visible & compilation fails
    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    76efc19 View commit details
    Browse the repository at this point in the history

  2. chore: update FabricExample's Podfile.lock

    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    947ac3d View commit details
    Browse the repository at this point in the history

  3. fix: move reactSetFrame: method to Paper specific section

    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    c2e020d View commit details
    Browse the repository at this point in the history

  4. fix: fix typo in ifdef directive

    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    f0c88c2 View commit details
    Browse the repository at this point in the history

  5. fix: temporary: move setActivityStateOrNil & setPointerEvents methods to 

    paper specific section
    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    b37a60a View commit details
    Browse the repository at this point in the history

  6. fix: add missing replaceAnimation prop (NOT TESTED) 

    1. move the prop to implemented section in JS
2. move the prop to "common" section in RNSScreenView interface
    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    6825875 View commit details
    Browse the repository at this point in the history

  7. fix: move notifyFinishTransitioning method to Paper specific section

    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    ce01586 View commit details
    Browse the repository at this point in the history

  8. fix: move notifyDismissCancelledWithDismissCount: method to Paper 

    specific section
    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    8a1525c View commit details
    Browse the repository at this point in the history

  9. fix: move notifyTransitionProgress:closing:goingForward: method to Paper 

    specific section

Aim: to ake project compile
    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    249d675 View commit details
    Browse the repository at this point in the history

  10. fix: remove duplication of prop setting 

    most likely some kind of merging artifact
    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    5e89e5b View commit details
    Browse the repository at this point in the history

  11. chore: change handling of unsupported props to noop

    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    d028f87 View commit details
    Browse the repository at this point in the history

  12. fix: move RNSScreenManager impl & def under !RN_FABRIC_ENABLED condition

    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    ebdbafa View commit details
    Browse the repository at this point in the history

  13. fix: remove duplicated prop update in updateProps method 

    most likely some kind of merge artifact
    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    cfd3842 View commit details
    Browse the repository at this point in the history

  14. fix: temporary: exclude usages of customAnimationOnSwipe from Fabric 

    temporary solution until customAnimationOnSwipe is not added to
RNSScreenView on Fabric
    @kkafar
    kkafar committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    40d438a View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. fix: make the project compile 

    these directives should be removed once implementations ale fully merged
    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    e79ae5f View commit details
    Browse the repository at this point in the history

  2. chore: merge ScreenStack headers

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    a7e3012 View commit details
    Browse the repository at this point in the history

  3. chore: merge imports in ScreenStack impls

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    4ea96a7 View commit details
    Browse the repository at this point in the history

  4. chore: move initWithFrame: method & add sections

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    f9160d4 View commit details
    Browse the repository at this point in the history

  5. chore: move navigationController:didShowViewController:animated method 

    to Paper specific section

This method is not present in RNSScreenStackComponentView, therefore I
conclude it is not necessary at least for now
    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    22d0484 View commit details
    Browse the repository at this point in the history

  6. chore: merge presentationControllerDidDismiss: method

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    60b9d20 View commit details
    Browse the repository at this point in the history

  7. chore: move {mount,unmount}ChildComponentView:index: methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    30b3a1e View commit details
    Browse the repository at this point in the history

  8. chore: move takeSnapshot method

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    384df76 View commit details
    Browse the repository at this point in the history

  9. chore: merge didMoveToWindow methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    228aa31 View commit details
    Browse the repository at this point in the history

  10. chore: move mountingTransactionWillMountWithMetadata: method to 

    Fabric specific section
    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    bdd2c24 View commit details
    Browse the repository at this point in the history

  11. chore: merge maybeAddToParentAndUpdateContainer methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    c246467 View commit details
    Browse the repository at this point in the history

  12. chore: move markChildUpdated & didUpdateChildren methods to Paper 

    specific section
    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    c2c6252 View commit details
    Browse the repository at this point in the history

  13. chore: move insertReactSubview:atIndex: method to Paper specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    c91c43b View commit details
    Browse the repository at this point in the history

  14. chore: move removeReactSubview: method to paper specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    16fe33d View commit details
    Browse the repository at this point in the history

  15. chore: move didUpdateReactSubviews method to paper specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    906ce0d View commit details
    Browse the repository at this point in the history

  16. chore: merge reactAddControllerToClosestParent: methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    8c9585d View commit details
    Browse the repository at this point in the history

  17. chore: merge setModalViewControllers: methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    34f8cb3 View commit details
    Browse the repository at this point in the history

  18. chore: WIP: merge setPushViewControllers

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    ee139da View commit details
    Browse the repository at this point in the history

  19. chore: merge updateContainer methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    ed24d05 View commit details
    Browse the repository at this point in the history

  20. chore: move hitTest:withEvent: method to paper specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    8140571 View commit details
    Browse the repository at this point in the history

  21. refact: fix braces in updateContainer method

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    899b285 View commit details
    Browse the repository at this point in the history

  22. chore: move invalidate method to paper specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    35fd105 View commit details
    Browse the repository at this point in the history

  23. chore: merge dismissOnReload methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    bc27beb View commit details
    Browse the repository at this point in the history

  24. chore: move isInGestureResponseDistance:topScreen: method to paper 

    specific section
    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    0c57d95 View commit details
    Browse the repository at this point in the history

  25. chore: merge cancelTouchesInParent methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    844820c View commit details
    Browse the repository at this point in the history

  26. chore: merge gestureRecognizerShouldBegin: methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    fa21ff4 View commit details
    Browse the repository at this point in the history

  27. chore: move isScrollViewPanGestureRecognizer: method to paper specific 

    section

temporary -- unitl not implemented on fabric
    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    159e07a View commit details
    Browse the repository at this point in the history

  28. chore: move two gestureRecognizer:... methods to paper specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    c5a3093 View commit details
    Browse the repository at this point in the history

  29. chore: move two interactionController getters to paper specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    f0d45dc View commit details
    Browse the repository at this point in the history

  30. chore: move prepareForRecycle method to fabric specific section & finish 

    merging
    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    396d58e View commit details
    Browse the repository at this point in the history

  31. fix: add facebook::react namespace to C++ react types

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    7b66535 View commit details
    Browse the repository at this point in the history

  32. chore: remove RNSScreenStackComponentView.{h,mm} files

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    8b212d3 View commit details
    Browse the repository at this point in the history

  33. chore: add TODOs

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    7ea7005 View commit details
    Browse the repository at this point in the history

  34. chore: merge headers

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    7755d06 View commit details
    Browse the repository at this point in the history

  35. refact: apply linter suggestions

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    14e2dfa View commit details
    Browse the repository at this point in the history

  36. chore: initial impl setup

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    48c5d5a View commit details
    Browse the repository at this point in the history

  37. chore: merge props

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    7548166 View commit details
    Browse the repository at this point in the history

  38. chore: add pragma mark sections: Fabric specific, Paper specific

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    61edbe0 View commit details
    Browse the repository at this point in the history

  39. chore: move subviews methods to paper specific sections

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    ee4407b View commit details
    Browse the repository at this point in the history

  40. chore: merge hitTest:withEvent: methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    e30ade9 View commit details
    Browse the repository at this point in the history

  41. chore: move didSetProps: method to paper specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    9ba8a23 View commit details
    Browse the repository at this point in the history

  42. chore: move didUpdateReactSubviews to paper specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    888d5a7 View commit details
    Browse the repository at this point in the history

  43. chore: merge loadBackButtonImageInViewController methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    8a15b87 View commit details
    Browse the repository at this point in the history

  44. chore: merge buildAppearance:withConfig: methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    7aed355 View commit details
    Browse the repository at this point in the history

  45. chore: merge updateViewController:withConfig:animated: methods

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    03121b0 View commit details
    Browse the repository at this point in the history

  46. chore: move addSubviesToNavItem: method to Fabric specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    7ba7fea View commit details
    Browse the repository at this point in the history

  47. chore: move mountChildComponentView method to Fabric specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    36794a0 View commit details
    Browse the repository at this point in the history

  48. chore: move unmountChildComponentView: method to Fabric specific section

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    73f973e View commit details
    Browse the repository at this point in the history

  49. chore: move RCTComponentViewProtocol methods & conversion methods to 

    Fabric specific section
    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    42b9d9d View commit details
    Browse the repository at this point in the history

  50. fix: make implementations of StackHeaderConfigManager & 

    StackheaderSubviewManager depend on RN_FABRIC_ENABLED
    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    92744dc View commit details
    Browse the repository at this point in the history

  51. chore: remove RNSScreenStackHeaderConfigComponentView.{h,mm} files

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    b6ab6d2 View commit details
    Browse the repository at this point in the history

  52. refact: rename all references to RNSScreenStackHeaderComponentView

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    ac18602 View commit details
    Browse the repository at this point in the history

  53. chore: restore NS_ASSUME_NONNULL_{BEGIN,END} macros

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    c523870 View commit details
    Browse the repository at this point in the history

  54. refact: apply linter suggestions

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    bd73703 View commit details
    Browse the repository at this point in the history

  55. fix: restore RNSScreenManager on Fabric

    @WoLewicki
    WoLewicki committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    a0245cf View commit details
    Browse the repository at this point in the history

  56. Merge branch '@kkafar/merge-fabric-to-paper' of github.com:software-m… 

    …ansion/react-native-screens into @kkafar/merge-fabric-to-paper
    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    66adb09 View commit details
    Browse the repository at this point in the history

  57. refact: apply linter suggestion

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    57554c9 View commit details
    Browse the repository at this point in the history

  58. fix: remove merge artifact

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    0e73f8f View commit details
    Browse the repository at this point in the history

  59. chore: merge in base branch

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    f3c937e View commit details
    Browse the repository at this point in the history

  60. refact: apply linter suggestions

    @kkafar
    kkafar committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    f47cf9a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. fix: add *.mm sources to TestExample project

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    f1e9b9d View commit details
    Browse the repository at this point in the history

  2. chore: merge in base branch

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    cabd831 View commit details
    Browse the repository at this point in the history

  3. refact: apply linter suggestions

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    d447b7f View commit details
    Browse the repository at this point in the history

  4. fix: restore RNSScreenStackHeaderConfigManager for Fabric impl

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    fa8d395 View commit details
    Browse the repository at this point in the history

  5. fix: restore RNScreenStackmanager for Fabric impl

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5d2b1fb View commit details
    Browse the repository at this point in the history

  6. Merge branch '@kkafar/merge-fabric-to-paper-screen-stack' into @kkafa… 

    …r/merge-fabric-to-paper-screen-stack-header-config
    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    dae6c4c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into @kkafar/merge-fabric-to-paper

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    dfade18 View commit details
    Browse the repository at this point in the history

  8. Merge branch '@kkafar/merge-fabric-to-paper' into @kkafar/merge-fabri… 

    …c-to-paper-screen-stack
    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    8de3dc0 View commit details
    Browse the repository at this point in the history

  9. Merge branch '@kkafar/merge-fabric-to-paper-screen-stack' into @kkafa… 

    …r/merge-fabric-to-paper-screen-stack-header-config
    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    9a350ff View commit details
    Browse the repository at this point in the history

  10. fix: make TestsExample compile 

    Notice change of RNSScreenView#controller type from UIViewController to
RNSScreen
    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    953299e View commit details
    Browse the repository at this point in the history

  11. potentially important: remove RNSScreen *_controller field 

    from RNSScreenView implementation
    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    d46daff View commit details
    Browse the repository at this point in the history

  12. chore: move setViewToSnapshot & resetViewToScreen methods to Fabric 

    specific section
    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    3fa258d View commit details
    Browse the repository at this point in the history

  13. chore: merge viewWillAppear: methods

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5196876 View commit details
    Browse the repository at this point in the history

  14. chore: merge viewWillDisappear methods

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    a7e0329 View commit details
    Browse the repository at this point in the history

  15. chore: merge viewDidAppear methods

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    4f0ff72 View commit details
    Browse the repository at this point in the history

  16. chore: merge viewDidDisappear methods

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    2bf93c5 View commit details
    Browse the repository at this point in the history

  17. chore: merge viewDidLayoutSubviews methods

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    55e4e19 View commit details
    Browse the repository at this point in the history

  18. chore: move findFirstResponder method to paper specific section

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    77fe908 View commit details
    Browse the repository at this point in the history

  19. chore: move willMoveToParentViewController method to paper specific 

    section
    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    5193821 View commit details
    Browse the repository at this point in the history

  20. chore: move hideHeaderIfNecessary method to paper specific section

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    834ade9 View commit details
    Browse the repository at this point in the history

  21. chore: move traverseForScrollView: method to paper specific section

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    53fd009 View commit details
    Browse the repository at this point in the history

  22. chore: move methods connected to transitioning to paper specific section 

    temporary solution until it is not migrated
    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    b946e61 View commit details
    Browse the repository at this point in the history

  23. Merge branch '@kkafar/merge-fabric-to-paper' into @kkafar/merge-fabri… 

    …c-to-paper-screen-stack
    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    40b8122 View commit details
    Browse the repository at this point in the history

  24. refact: apply linter suggestions

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    c2925e3 View commit details
    Browse the repository at this point in the history

  25. Merge branch '@kkafar/merge-fabric-to-paper-screen-stack' into @kkafa… 

    …r/merge-fabric-to-paper-screen-stack-header-config
    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    d1844ba View commit details
    Browse the repository at this point in the history

  26. chore: remove leftover comments

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    44368ed View commit details
    Browse the repository at this point in the history

  27. refact: rename BASE_VIEW -> RNS_BASE_VIEW

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    0ab05f3 View commit details
    Browse the repository at this point in the history

  28. refact: apply linter suggestions

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    15a30cf View commit details
    Browse the repository at this point in the history

  29. refact: rename EXPECTED_VIEW -> RNS_EXPECTED_VIEW§

    @kkafar
    kkafar committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    0afaafd View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2022

  1. chore: restore back initWithBridge method for Fabric 

    Fabric implementation does not need it, but RNSScreenManager is required
    @kkafar
    kkafar committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    d0f128d View commit details
    Browse the repository at this point in the history

  2. fix: restore back notifyFinishTransitioning method for paper

    @kkafar
    kkafar committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    d6ccca1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into @kkafar/merge-fabric-to-paper

    @kkafar
    kkafar committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    3d8a6a0 View commit details
    Browse the repository at this point in the history

  4. fix: tvOS: exclude props not existion on tv platform

    @kkafar
    kkafar committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    d465135 View commit details
    Browse the repository at this point in the history

  5. chore: remove unnecessary header guard directives from RNSConvert.h

    @kkafar
    kkafar committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    f0e42f0 View commit details
    Browse the repository at this point in the history

  6. chore: remove check if passed view is of class RNSScreenView 

    see: #1415 (comment)
    @kkafar
    kkafar committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    d9bb8a6 View commit details
    Browse the repository at this point in the history

  7. Merge branch '@kkafar/merge-fabric-to-paper' into @kkafar/merge-fabri… 

    …c-to-paper-screen-stack
    @kkafar
    kkafar committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    deee6fb View commit details
    Browse the repository at this point in the history

  8. Merge branch '@kkafar/merge-fabric-to-paper-screen-stack' into @kkafa… 

    …r/merge-fabric-to-paper-screen-stack-header-config
    @kkafar
    kkafar committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    3dfce64 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Merge branch 'main' into @kkafar/merge-fabric-to-paper-screen-stack-h… 

    …eader-config
    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    86e64da View commit details
    Browse the repository at this point in the history

  2. refact: apply linter suggestion

    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    d2e5771 View commit details
    Browse the repository at this point in the history

  3. fix: remove merge artifacts

    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    72a766b View commit details
    Browse the repository at this point in the history

  4. fix: restore RNSScreenStackHeaderSubviewManager for Fabric implementa… 

    …tion
    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    838dbc8 View commit details
    Browse the repository at this point in the history

  5. fix: surround RNSScreenStackHeaderConfigCls with guard directive 

    This is required as RCTComponentViewProtocol is not visible on paper
    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    56679d3 View commit details
    Browse the repository at this point in the history

  6. refact: copy comment from didSetProps method to 

    layoutNavigationControllerView
    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    21314af View commit details
    Browse the repository at this point in the history

  7. refact: remove leftover comments

    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    55a4d95 View commit details
    Browse the repository at this point in the history

  8. chore: replace cust getFontFamliyPropValue method with one provided by 

    RCTConversions
    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    84b6a01 View commit details
    Browse the repository at this point in the history

  9. chore: replace custom stringToPropValue method with one provided by 

    RCTConversions
    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    3f19111 View commit details
    Browse the repository at this point in the history

  10. refact: move reactSubviews method to common section

    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    5128931 View commit details
    Browse the repository at this point in the history

  11. chore: settle down to single convention of specifing superclasses

    @kkafar
    kkafar committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    fd57615 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. refact: remove // done comments for the 3rd time...

    @kkafar
    kkafar committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    8e16be2 View commit details
    Browse the repository at this point in the history

  2. refact: ifndef -> ifdef + else (for the 3rd time) 

    merge artifacts!
    @kkafar
    kkafar committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    9ec99bc View commit details
    Browse the repository at this point in the history

  3. refact: remove merge artifact: unused import

    @kkafar
    kkafar committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    1e30773 View commit details
    Browse the repository at this point in the history

  4. chore: move reactSubviews prop to common section in header file 

    also remove redeclaration in implementation
    @kkafar
    kkafar committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    0a11a10 View commit details
    Browse the repository at this point in the history

  5. refact: linter suggestion

    @kkafar
    kkafar committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    68435f2 View commit details
    Browse the repository at this point in the history

  6. fix: make reactSubviews prop fabric specific 

    This is changed when ScreenStackHeaderSubview is merged
    @kkafar
    kkafar committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    b917b68 View commit details
    Browse the repository at this point in the history

  7. refact: optimize imports

    @kkafar
    kkafar committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    6818798 View commit details
    Browse the repository at this point in the history

  8. refact: remove unnecessary _backgroundSharedColor property

    @kkafar
    kkafar committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    91ccf27 View commit details
    Browse the repository at this point in the history

  9. chore: move call to didMoveToParentViewController to common section

    @kkafar
    kkafar committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    7460d71 View commit details
    Browse the repository at this point in the history