Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad initial frame position #1463

Merged
merged 7 commits into from
Jun 1, 2022
Merged

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jun 1, 2022

Description

Fix the bug causing the view to have wrong offset for quick moment when using non-default stack animation.

Changes

TODO

Screenshots / GIFs

Before

See that view has incorrect offset (it does not respect the navigation bar):

before

After

This effects no longer occurs.

Test code and steps to reproduce

  • Test1463 in FabricTestExample app

Checklist

@kkafar kkafar force-pushed the @kkafar/fix-bad-initial-frame-position branch from fa13143 to 8bdcff0 Compare June 1, 2022 15:21
kkafar and others added 5 commits June 1, 2022 17:45
@kkafar kkafar force-pushed the @kkafar/fix-bad-initial-frame-position branch from c46fd05 to adb7736 Compare June 1, 2022 15:46
Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com>
@kkafar kkafar force-pushed the @kkafar/fix-bad-initial-frame-position branch from 9fc4bf9 to b613315 Compare June 1, 2022 15:54
@kkafar kkafar marked this pull request as ready for review June 1, 2022 16:18
@kkafar kkafar requested a review from WoLewicki June 1, 2022 16:28
@kkafar kkafar merged commit ba6b06b into main Jun 1, 2022
@kkafar kkafar deleted the @kkafar/fix-bad-initial-frame-position branch June 1, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants