Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement onFinishTransitioning event for ScreenStack for Fabric #1471

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jun 2, 2022

Description

Implemented onFinishTransitioning event for ScreenStack on Fabric.

Changes

  • Added event type to codegen
  • Added event dispatch on Fabric
  • Small refactoring of event emitting methods so they are shared between architerctures.

Test code and steps to reproduce

No new tests

This event was used only with react-naviagation v4.

Checklist

@kkafar kkafar changed the title feat: implement onFinishTransitioning event for ScreenStack for Fabric feat: implement onFinishTransitioning event for ScreenStack for Fabric Jun 21, 2022
@kkafar kkafar marked this pull request as ready for review June 22, 2022 14:56
@kkafar kkafar merged commit 3a8a29c into main Jun 22, 2022
@kkafar kkafar deleted the @kkafar/fabric-screen-stack-on-finish-transitioning branch June 22, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant