fix: get properties from top-most screen on swipe

[kacperkapusciak]

Description

This PR fixes an issue on which swipeDirection was required to be set on both on current and previous screen because the value after one tick was incorrectly taken from the previous screen.

Thanks @WoLewicki for the solution 👏

Screenshots / GIFs

Before

Screen.Recording.2022-07-04.at.11.41.47.mov

After

Screen.Recording.2022-07-04.at.11.40.11.mov

Test code and steps to reproduce

TestsExample/Test1509.tsx

Checklist

• Included code example that can be used to test this change

[WoLewicki]

Good job 🎉

[hirbod]

@WoLewicki do you still remember the fullScreen swipe issue I've showed you at App.js conf?
When you swipe on the edge, it will trigger the default swipe gesture instead of the custom for fullScreen.

Maybe thats a good point to fix this as well :D

[WoLewicki]

@hirbod good point! I'll look into it. Do you have a quick repro for this and could paste it even here?

[hirbod]

@WoLewicki this should work
https://snack.expo.dev/@hirbod/swipe-pop-issue

I could not reproduce this in Expo Go though.

Here is a video from my app. Depending on where I swipe (edge) or somewhere in the screen, it will have a shadow left or not. Its not a big deal though.

RPReplay_Final1657010606.mp4

[kkafar]

Hi @hirbod
I'm looking at your snack right now & that's right :D Depending on where your gesture starts it is handled by different gesture recognisers. When you start the gesture near the edge native animation is being played, otherwise animation defaults to 'simple_push'. So if you want to have the same effect on whole screen you should try to set animation: "simple_push".
However I see that this is not the best behaviour, and we could maybe set the animation to 'simple_push' by default.

[hirbod]

That might be an option. A third option would be to have 'simple_push_with_shadow' :D

[WoLewicki]

But still the native header transition is only possible with the default gesture recognizer 😢

[hirbod]

Yeah the header is not that bad though, the shadow is also not a big deal breaker - just a visual thing