fix: remove checks for Fabric that did not work #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As @tsapeta suggested, checking if Fabric is enabled in the top-level scope returns
falseso our checks did not change anything and therefore seem to not be needed. The only needed is inReanimatedNativeStackScreen, and it was correctly resolved totrue, but using the prop added toglobalbyreanimatedseems safer since we are in context ofreanimatedanyways. All the other checks were removed.Test code and steps to reproduce
Build an app on Fabric and see that everything works the same.