fix: take top stack view child from reactSubviews in gesture recogniction logic #1521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1476
Changes
Replaced references to
(RNSScreenView *)_controller.viewControllers.lastObject.view;
with_reactSubviews.lastObject
in gesture recognition logic as it also handles modals & has "more up-to-date" value.Screenshots / GIFs
Before
See the issue: #1476
After
Both using
react-native-screens/native-stack
&@react-navigation/native-stack
:Screen.Recording.2022-07-08.at.11.32.41.mov
Test code and steps to reproduce
{FabricTestExample,TestsExample}/Test1476
Checklist