fix: wrap Screen with ScreenContext #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperkapusciak
commented
Jul 20, 2022
Comment on lines
+414
to
+421
| class Screen extends React.Component<ScreenProps> { | ||
| static contextType = ScreenContext; | ||
|
|
||
| render() { | ||
| const ScreenWrapper = this.context || InnerScreen; | ||
| return <ScreenWrapper {...this.props} />; | ||
| } | ||
| } |
There was a problem hiding this comment.
Alternatively, we could use a functional syntax here eg.:
const Screen = React.forwardRef<any, any>(function Screen(props, ref) {
const TurboScreen = React.useContext(ScreenContext);
const ScreenWrapper = TurboScreen || InnerScreen;
return <ScreenWrapper {...props} ref={ref} />;
});which I think here is more complicated than the class-based.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes a
Screenwhich is prewrapped withScreenContext. PreviousScreenimplementation is internally renamedInnerScreenand should have no effect on the outside use of the library.This change is necessary to use
useReanimatedTransitionProgressfeature without additional setup within react-navigation repo.Discussed in detail in react-navigation/react-navigation#10585
Closes react-navigation/react-navigation#10585
Test code and steps to reproduce
Test1539.tsxinTestsExampleproject.Checklist