feat(iOS): back button subview for Fabric

[kkafar]

Description

Resolves #1563

The issue was tricky & deceptive.

In RNSScreenStackHeaderSubview during initialisation we assigned to _prop default prop values. We used it later in updateProps:oldProps: to check whether the type changed - if it was the case we called setType, otherwise there was no action taken.

With such setup, in case of newProps.type value, being the same as _prop.type the type property would not get initialised and default to 0 leading to crashes later on.

NOTE: We need to verify this in other components, as we are using there the same faulty mechanism.

Changes

• Removed if-check whether the type property should be updated
• Unified ifdef'd (RN_NEW_ARCH_ENABLED) sections of code
• Updated test screen & added it to FabricTestExample
• Removed the warning

Test code and steps to reproduce

See Test1157

Checklist

• Included code example that can be used to test this change
• Ensured that CI passes (known issue with iOS e2e)

[marcocaldera]

This PR is merged but hasn't been included in any of the releases. What is the plan for fixing this issue?

[Kundannetset]

Invariant Violation: requireNativeComponent: "RNSScreenStackHeaderSubview" was not found in the UIManager.

[Kundannetset]

@marcocaldera @kkafar @ckknight @Minishlink
any update

Invariant Violation: requireNativeComponent: "RNSScreenStackHeaderSubview" was not found in the UIManager.

[kkafar]

Hey @kundannetsetDemo the issue you posted is not related and AFAIK is not really an issue. Just make sure to reset your node_modules & pod cache. For example with:

rm -fr node_modules yarn.lock ios/build ios/Pods ios/Podfile.lock && yarn install && cd ios && pod install

or in case this issue happens on Android:

rm -fr node_modules yarn.lock android/build android/app/build && yarn install