chore: support for React Native 0.71.0 #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recommended by upgrade helper
Recommended by upgrade helper
Recommended by upgrade helper
Suggested by upgrade helper
Suggested by upgrade helper
Suggested by upgrade helper
Suggested by upgrade helper
Suggested by upgrade helper I do not understang why jni directory is being deleted. It completely destroys current autolinking mechanism...
HOW DOES THE AUTOLINKING OF CUSTOM STATE WORK NOW?
Suggested by upgrade helper HOW DOES AUTOLINKING OF CUSTOM STATE WORK NOW?
Suggested by upgarde helper...
Suggested by upgrade helper
Suggested by upgrade helper
## Description Make `ios-build-test-fabric` workflow build `FabricTestExample` instead of `FabricExample` This is done to unify behaviour between platforms as `android-build-test-fabric` builds `FabricTestExample`. ## Changes Edited working directory of workflow. ## Checklist - [x] Ensured that CI passes (cherry picked from commit f8dfd27)
This is necesarry, as React Native started to include some C++ headers,
which are invisible otherwise and cause compilation error.
kkafar
changed the title
This was referenced Jan 10, 2023
## Description Should be merged to #1631. Build status: * [x] Android * [x] iOS ## Changes Mostly followed up instructions from [upgradle helper](https://react-native-community.github.io/upgrade-helper/?from=0.70.1&to=0.71.0-rc.6) with some minor tweaks (ts configuration, etc.) ## Test code and steps to reproduce Run `TestsExample` ## Checklist - [ ] Ensured that CI passes
## Description Should be merged to #1631. Build status: * [x] Android * [x] iOS But both application crash in runtime due to some issue with reanimated -- will be done with in followup PR ## Changes Mostly followed up instructions from [upgradle helper](https://react-native-community.github.io/upgrade-helper/?from=0.70.1&to=0.71.0-rc.6) with some minor tweaks (ts configuration, etc.) ## Test code and steps to reproduce Run `FabricExample` ## Checklist - [ ] Ensured that CI passes
This was referenced Jan 11, 2023
|
I'm really sorry for doing so but any timeline for when the support added through this PR will be published on npm? |
|
Hi @varemenos, |
kkafar
added a commit
that referenced
this pull request
Jan 18, 2023
## Description Issues * [x] ~~`activityState` is set to `0.0` by default in codegened files despite being explicitly set to `WithDefault<Float, -1.0>` in config (it should be `-1.0`). Tested it multiple times it looks like you can't set number < 0 for default when using TypeScript - tested with both `Int32` and `Float` (with Flow it worked fine).~~ * [x] ~~`yarn lint` fails~~ * [x] ~#1631 There are no other differences between codegened files -- I checked it file by file with diff tool. Update: It was confirmed by React Native developer that this indeed is a bug and will be fixed with 0.71. Update: * facebook/react-native#34800 was merged and is available is `0.71` rc branches of React Native. ### ***Important note*** Merging this PR will be breaking change for Fabric support for `react-native` versions lower than `0.71.0` (`activityState` & `sheetCornerRadius` will be broken). ## Changes * Migrated codegen spec files from Flow to TS. * Also bumped `@types/react-native` to `0.69.6` [(see explanation)](d2ed6ec) * Had to do some minor type-fixing in our types * Had to patch `react-navigation-stack` types. This dependency is required for v4. <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce I created a backup of codegened code from before this PR. After applying these changes I ran: `./gradlew :react-native-screens:generateCodegenArtifactsFromSchema` (or just build application) and then I manually compared codegend files using diff checker - the output code is the same. ## Checklist - [x] Ensured that CI passes (there is a known issue with e2e on iOS, it will be handled separately)
1 task
kkafar
added a commit
that referenced
this pull request
Jan 19, 2023
## Description Added a row in Fabric support table saying that as of [version `3.19.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.19.0) of this project, Fabric is supported only for react-native 0.71+. Support for lower versions has been dropped. This is mainly due to changes in #1631 & #1600 ## Changes Just updated the table & added explanation ## Checklist - [x] Ensured that CI passes
renovate bot
referenced
this pull request
in valora-inc/wallet
Oct 17, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://github.com/software-mansion/react-native-screens) | [`^3.18.2` -> `^3.25.0`](https://renovatebot.com/diffs/npm/react-native-screens/3.18.2/3.25.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.25.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.25.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.24.0...3.25.0) #### What's Changed Minor release focused on bug fixes & internals. #### 🐛 Bug fixes - iOS: Add missing call to super method in `RNSScreenView#finalizeUpdates` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1855](https://github.com/software-mansion/react-native-screens/pull/1855) - Android: Shorten alpha animation to 83ms on default enter-out by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1835](https://github.com/software-mansion/react-native-screens/pull/1835) - iOS: Wrong title in back button menu for screens w/ hidden header by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1866](https://github.com/software-mansion/react-native-screens/pull/1866) - iOS: Full window overlay cannot receive tap when modal is full screen by [@​intergalacticspacehighway](https://github.com/intergalacticspacehighway) in [https://github.com/software-mansion/react-native-screens/pull/1872](https://github.com/software-mansion/react-native-screens/pull/1872) #### 🔢 Miscellaneous - Reinstall deps & pods in example apps after release by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1862](https://github.com/software-mansion/react-native-screens/pull/1862) - Fix typo in docs on `sheetCornerRadius` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1863](https://github.com/software-mansion/react-native-screens/pull/1863) - Use `PlatformColor` instead of plain `string` for color related props by [@​retyui](https://github.com/retyui) in [https://github.com/software-mansion/react-native-screens/pull/1846](https://github.com/software-mansion/react-native-screens/pull/1846) - Android: Migrate `replaceSystemWindowInsets` to `Builder.setSystemWindowInsets` by [@​kirillzyusko](https://github.com/kirillzyusko) in [https://github.com/software-mansion/react-native-screens/pull/1868](https://github.com/software-mansion/react-native-screens/pull/1868) #### New Contributors - [@​intergalacticspacehighway](https://github.com/intergalacticspacehighway) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1872](https://github.com/software-mansion/react-native-screens/pull/1872) - [@​retyui](https://github.com/retyui) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1846](https://github.com/software-mansion/react-native-screens/pull/1846) **Full Changelog**: software-mansion/react-native-screens@3.24.0...3.25.0 ### [`v3.24.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.24.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.23.0...3.24.0) Minor release focused on fixing build issues reported in [#​1859](https://github.com/software-mansion/react-native-screens/issues/1859). #### What's Changed #### 🐛 Bug fixes - Bad parameter type in `toggleCancelButton` search bar command by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1854](https://github.com/software-mansion/react-native-screens/pull/1854) - Add missing iOS API availbility checks by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1860](https://github.com/software-mansion/react-native-screens/pull/1860) #### 🔢 Miscellaneous - Update RN + other deps in example apps by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1847](https://github.com/software-mansion/react-native-screens/pull/1847) - Annotate `sheetExpandsWhenScrollingToEdge` prop as iOS specific by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1851](https://github.com/software-mansion/react-native-screens/pull/1851) - Improve readability of C++ namespaced types by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1856](https://github.com/software-mansion/react-native-screens/pull/1856) **Full Changelog**: software-mansion/react-native-screens@3.23.0...3.24.0 ### [`v3.23.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.23.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.22.1...3.23.0) #### What's Changed #### 🐛 Bug fixes - Headerheight incorrect on phones with dynamic island by [@​dylancom](https://github.com/dylancom) in [https://github.com/software-mansion/react-native-screens/pull/1784](https://github.com/software-mansion/react-native-screens/pull/1784) - Buggy search bar / large title behaviour on Fabric by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1825](https://github.com/software-mansion/react-native-screens/pull/1825) - Make RNSFullWindowOverlay a modal for accessibility by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1842](https://github.com/software-mansion/react-native-screens/pull/1842) - Calculate large headers in `useHeaderHeight` hook by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1844](https://github.com/software-mansion/react-native-screens/pull/1844) #### 👍 Improvements - Add onGestureCancel event by [@​piaskowyk](https://github.com/piaskowyk) in [https://github.com/software-mansion/react-native-screens/pull/1810](https://github.com/software-mansion/react-native-screens/pull/1810) - Add support for search bar placement by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1843](https://github.com/software-mansion/react-native-screens/pull/1843) #### 🔢 Miscellaneous - Update `tough-cookie` and `semver` dependencies by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1823](https://github.com/software-mansion/react-native-screens/pull/1823) - Bump versions of RNScreens, FBReactNativeSpec and RCTAppDelegate deps by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1827](https://github.com/software-mansion/react-native-screens/pull/1827) - Update `word-wrap` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1834](https://github.com/software-mansion/react-native-screens/pull/1834) - Format code in test examples by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1812](https://github.com/software-mansion/react-native-screens/pull/1812) - Unify class & method naming with respect to conventions by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1841](https://github.com/software-mansion/react-native-screens/pull/1841) #### New Contributors - [@​piaskowyk](https://github.com/piaskowyk) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1810](https://github.com/software-mansion/react-native-screens/pull/1810) - [@​tboba](https://github.com/tboba) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1823](https://github.com/software-mansion/react-native-screens/pull/1823) **Full Changelog**: software-mansion/react-native-screens@3.22.1...3.23.0 ### [`v3.22.1`](https://github.com/software-mansion/react-native-screens/releases/tag/3.22.1) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.22.0...3.22.1) Patch release bringing back old behaviour of `formSheet` modal on iOS when using `@react-navigation/native-stack`. #### What's Changed ##### Fixes - fix: move setting default values of medium-detent related props to `InnerScreen` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1811](https://github.com/software-mansion/react-native-screens/pull/1811) ##### Internal - chore: fix CI by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1803](https://github.com/software-mansion/react-native-screens/pull/1803) - chore(deps): update selected deps in examples by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1807](https://github.com/software-mansion/react-native-screens/pull/1807) - chore: fix typo in docs by [@​aleqsio](https://github.com/aleqsio) in [https://github.com/software-mansion/react-native-screens/pull/1808](https://github.com/software-mansion/react-native-screens/pull/1808) #### New Contributors - [@​aleqsio](https://github.com/aleqsio) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1808](https://github.com/software-mansion/react-native-screens/pull/1808) **Full Changelog**: software-mansion/react-native-screens@3.22.0...3.22.1 ### [`v3.22.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.22.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.21.1...3.22.0) Minor release fixing some build issues that could happen on older Xcode versions & with Android SDK 34. #### What's Changed - fix: canvas nullability in ScreenStack for Android SDK 34 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1795](https://github.com/software-mansion/react-native-screens/pull/1795) - fix: ifdef orientation code that requries iOS 16 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1794](https://github.com/software-mansion/react-native-screens/pull/1794) - chore: update & reinstall selected deps by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1798](https://github.com/software-mansion/react-native-screens/pull/1798) **Full Changelog**: software-mansion/react-native-screens@3.21.1...3.22.0 ### [`v3.21.1`](https://github.com/software-mansion/react-native-screens/releases/tag/3.21.1) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.21.0...3.21.1) Patch release adding internal `isNewBackTitleImplementation` constant for use in `@react-navigation/native-stack`. See [#​1791](https://github.com/software-mansion/react-native-screens/issues/1791) & [https://github.com/react-navigation/react-navigation/pull/11423](https://github.com/react-navigation/react-navigation/pull/11423) for details. ### [`v3.21.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.21.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.20.0...3.21.0) Minor release with support for React Native 0.72 on New Architecture, fixing some bugs and adding new functionalities. Please note that support for `react-navigation` v4 has been dropped with this version and you can no longer use `native-stack` v4 starting from this version. It might be considered a **BREAKING CHANGE** so be careful with updating. #### What's Changed - chore: migrate codegen to TypeScript by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1600](https://github.com/software-mansion/react-native-screens/pull/1600) - chore: update README on Fabric support by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1687](https://github.com/software-mansion/react-native-screens/pull/1687) - feat(iOS): back button subview for Fabric by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1581](https://github.com/software-mansion/react-native-screens/pull/1581) - fix(iOS): image loading for back button on Fabric by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1688](https://github.com/software-mansion/react-native-screens/pull/1688) - chore: refactor medium detent iOS implementation by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1699](https://github.com/software-mansion/react-native-screens/pull/1699) - feat(Android): add native default animations on Android 13 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1693](https://github.com/software-mansion/react-native-screens/pull/1693) - chore: fix e2e detox tests & `Example` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1681](https://github.com/software-mansion/react-native-screens/pull/1681) - fix(iOS): status bar does not respect app theme by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1708](https://github.com/software-mansion/react-native-screens/pull/1708) - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1709](https://github.com/software-mansion/react-native-screens/pull/1709) - chore: change fabric flag by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1705](https://github.com/software-mansion/react-native-screens/pull/1705) - chore(CI): extend timeout for Android e2e by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1711](https://github.com/software-mansion/react-native-screens/pull/1711) - chore: update deps in examples by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1714](https://github.com/software-mansion/react-native-screens/pull/1714) - chore: update library & examples dependencies by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1721](https://github.com/software-mansion/react-native-screens/pull/1721) - fix: Android build for `compileSdk < 33` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1723](https://github.com/software-mansion/react-native-screens/pull/1723) - feat: add imperative API for search bar by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1610](https://github.com/software-mansion/react-native-screens/pull/1610) - chore(deps): bump shell-quote from 1.6.1 to 1.8.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1725](https://github.com/software-mansion/react-native-screens/pull/1725) - chore: improve Android anim resource management by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1727](https://github.com/software-mansion/react-native-screens/pull/1727) - chore: fix typo in build script by [@​Jace-Samsung](https://github.com/Jace-Samsung) in [https://github.com/software-mansion/react-native-screens/pull/1733](https://github.com/software-mansion/react-native-screens/pull/1733) - chore: set library namespace in build script by [@​Sprimage](https://github.com/Sprimage) in [https://github.com/software-mansion/react-native-screens/pull/1717](https://github.com/software-mansion/react-native-screens/pull/1717) - fix(iOS): back button not respecting style options by [@​tyler-coleman](https://github.com/tyler-coleman) in [https://github.com/software-mansion/react-native-screens/pull/1726](https://github.com/software-mansion/react-native-screens/pull/1726) - chore: override `onCreate` in example apps by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1736](https://github.com/software-mansion/react-native-screens/pull/1736) - feat: add `setText` command on SearchBar by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1739](https://github.com/software-mansion/react-native-screens/pull/1739) - chore(deps): bump activesupport from 6.1.4.6 to 7.0.4.3 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1744](https://github.com/software-mansion/react-native-screens/pull/1744) - fix: do not apply namespace if it is not available in agp by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1749](https://github.com/software-mansion/react-native-screens/pull/1749) - chore(deps): bump vm2 from 3.9.14 to 3.9.15 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1752](https://github.com/software-mansion/react-native-screens/pull/1752) - fix: use new rotation API for iOS 16 by [@​kirillzyusko](https://github.com/kirillzyusko) in [https://github.com/software-mansion/react-native-screens/pull/1732](https://github.com/software-mansion/react-native-screens/pull/1732) - chore: improve Android 13 animations by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1756](https://github.com/software-mansion/react-native-screens/pull/1756) - chore(deps): bump vm2 from 3.9.15 to 3.9.16 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1755](https://github.com/software-mansion/react-native-screens/pull/1755) - fix: ScreenStackHeaderConfig type by [@​tomekzaw](https://github.com/tomekzaw) in [https://github.com/software-mansion/react-native-screens/pull/1760](https://github.com/software-mansion/react-native-screens/pull/1760) - feat: remove v4 from repo by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1790](https://github.com/software-mansion/react-native-screens/pull/1790) - fix:Compatible with version 0.72 by [@​NiuGuohui](https://github.com/NiuGuohui) in [https://github.com/software-mansion/react-native-screens/pull/1765](https://github.com/software-mansion/react-native-screens/pull/1765) - fix: proper handling of header events on Fabric and bumping examples to 0.72 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1783](https://github.com/software-mansion/react-native-screens/pull/1783) - feat: prevent native back button dismissal on iOS by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1773](https://github.com/software-mansion/react-native-screens/pull/1773) #### New Contributors - [@​Jace-Samsung](https://github.com/Jace-Samsung) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1733](https://github.com/software-mansion/react-native-screens/pull/1733) - [@​Sprimage](https://github.com/Sprimage) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1717](https://github.com/software-mansion/react-native-screens/pull/1717) - [@​tyler-coleman](https://github.com/tyler-coleman) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1726](https://github.com/software-mansion/react-native-screens/pull/1726) - [@​NiuGuohui](https://github.com/NiuGuohui) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1765](https://github.com/software-mansion/react-native-screens/pull/1765) **Full Changelog**: software-mansion/react-native-screens@3.20.0...3.21.0 ### [`v3.20.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.20.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.19.0...3.20.0) Minior release aimed at fixing [#​1686](https://github.com/software-mansion/react-native-screens/issues/1686) (change of default behaviour for `stackPresentation: 'formSheet'`). No other changes were introduced with this release. Next "feature" release is in preparation. **Full Changelog**: software-mansion/react-native-screens@3.19.0...3.20.0 ### [`v3.19.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.19.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.18.2...3.19.0) Minor release with support for React Native 0.71 **Important**: Since this version, Fabric is only supported for React Native 0.71+. Support for older versions has beed dropped. #### 🐛 Bug fixes - Try to apply pointer events behaviors in overlay by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1582](https://github.com/software-mansion/react-native-screens/pull/1582) - Make enabling device orientation notifications internal by [@​kacperkapusciak](https://github.com/kacperkapusciak) & [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1596](https://github.com/software-mansion/react-native-screens/pull/1596) - Fix back button menu for headerBackTitleVisible prop by [@​kacperkapusciak](https://github.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-screens/pull/1646](https://github.com/software-mansion/react-native-screens/pull/1646) - Override requiresMainQueueSetup in RNSScreenManager by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1670](https://github.com/software-mansion/react-native-screens/pull/1670) #### 👍 Improvements - Support for React Native 0.71.0 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1631](https://github.com/software-mansion/react-native-screens/pull/1631) - Clarify installation instructions for Android by [@​evan1715](https://github.com/evan1715) in [https://github.com/software-mansion/react-native-screens/pull/1633](https://github.com/software-mansion/react-native-screens/pull/1633) #### 🔢 Miscellaneous - Fix FabricTestExample fails to start due to new `react-native.config.js` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1624](https://github.com/software-mansion/react-native-screens/pull/1624) - Examples stopped to work after RN issue by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1632](https://github.com/software-mansion/react-native-screens/pull/1632) - Exclude android/.settings file form repo by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1642](https://github.com/software-mansion/react-native-screens/pull/1642) - Bump deps & fix tvOS build by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1667](https://github.com/software-mansion/react-native-screens/pull/1667) - Unify CI between platforms by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1676](https://github.com/software-mansion/react-native-screens/pull/1676) #### New Contributors - [@​evan1715](https://github.com/evan1715) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1633](https://github.com/software-mansion/react-native-screens/pull/1633) **Full Changelog**: software-mansion/react-native-screens@3.18.2...3.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
bakoushin
referenced
this pull request
in valora-inc/wallet
Oct 17, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-screens](https://github.com/software-mansion/react-native-screens) | [`^3.18.2` -> `^3.25.0`](https://renovatebot.com/diffs/npm/react-native-screens/3.18.2/3.25.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>software-mansion/react-native-screens (react-native-screens)</summary> ### [`v3.25.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.25.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.24.0...3.25.0) #### What's Changed Minor release focused on bug fixes & internals. #### 🐛 Bug fixes - iOS: Add missing call to super method in `RNSScreenView#finalizeUpdates` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1855](https://github.com/software-mansion/react-native-screens/pull/1855) - Android: Shorten alpha animation to 83ms on default enter-out by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1835](https://github.com/software-mansion/react-native-screens/pull/1835) - iOS: Wrong title in back button menu for screens w/ hidden header by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1866](https://github.com/software-mansion/react-native-screens/pull/1866) - iOS: Full window overlay cannot receive tap when modal is full screen by [@​intergalacticspacehighway](https://github.com/intergalacticspacehighway) in [https://github.com/software-mansion/react-native-screens/pull/1872](https://github.com/software-mansion/react-native-screens/pull/1872) #### 🔢 Miscellaneous - Reinstall deps & pods in example apps after release by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1862](https://github.com/software-mansion/react-native-screens/pull/1862) - Fix typo in docs on `sheetCornerRadius` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1863](https://github.com/software-mansion/react-native-screens/pull/1863) - Use `PlatformColor` instead of plain `string` for color related props by [@​retyui](https://github.com/retyui) in [https://github.com/software-mansion/react-native-screens/pull/1846](https://github.com/software-mansion/react-native-screens/pull/1846) - Android: Migrate `replaceSystemWindowInsets` to `Builder.setSystemWindowInsets` by [@​kirillzyusko](https://github.com/kirillzyusko) in [https://github.com/software-mansion/react-native-screens/pull/1868](https://github.com/software-mansion/react-native-screens/pull/1868) #### New Contributors - [@​intergalacticspacehighway](https://github.com/intergalacticspacehighway) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1872](https://github.com/software-mansion/react-native-screens/pull/1872) - [@​retyui](https://github.com/retyui) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1846](https://github.com/software-mansion/react-native-screens/pull/1846) **Full Changelog**: software-mansion/react-native-screens@3.24.0...3.25.0 ### [`v3.24.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.24.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.23.0...3.24.0) Minor release focused on fixing build issues reported in [#​1859](https://github.com/software-mansion/react-native-screens/issues/1859). #### What's Changed #### 🐛 Bug fixes - Bad parameter type in `toggleCancelButton` search bar command by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1854](https://github.com/software-mansion/react-native-screens/pull/1854) - Add missing iOS API availbility checks by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1860](https://github.com/software-mansion/react-native-screens/pull/1860) #### 🔢 Miscellaneous - Update RN + other deps in example apps by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1847](https://github.com/software-mansion/react-native-screens/pull/1847) - Annotate `sheetExpandsWhenScrollingToEdge` prop as iOS specific by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1851](https://github.com/software-mansion/react-native-screens/pull/1851) - Improve readability of C++ namespaced types by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1856](https://github.com/software-mansion/react-native-screens/pull/1856) **Full Changelog**: software-mansion/react-native-screens@3.23.0...3.24.0 ### [`v3.23.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.23.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.22.1...3.23.0) #### What's Changed #### 🐛 Bug fixes - Headerheight incorrect on phones with dynamic island by [@​dylancom](https://github.com/dylancom) in [https://github.com/software-mansion/react-native-screens/pull/1784](https://github.com/software-mansion/react-native-screens/pull/1784) - Buggy search bar / large title behaviour on Fabric by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1825](https://github.com/software-mansion/react-native-screens/pull/1825) - Make RNSFullWindowOverlay a modal for accessibility by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1842](https://github.com/software-mansion/react-native-screens/pull/1842) - Calculate large headers in `useHeaderHeight` hook by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1844](https://github.com/software-mansion/react-native-screens/pull/1844) #### 👍 Improvements - Add onGestureCancel event by [@​piaskowyk](https://github.com/piaskowyk) in [https://github.com/software-mansion/react-native-screens/pull/1810](https://github.com/software-mansion/react-native-screens/pull/1810) - Add support for search bar placement by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1843](https://github.com/software-mansion/react-native-screens/pull/1843) #### 🔢 Miscellaneous - Update `tough-cookie` and `semver` dependencies by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1823](https://github.com/software-mansion/react-native-screens/pull/1823) - Bump versions of RNScreens, FBReactNativeSpec and RCTAppDelegate deps by [@​tboba](https://github.com/tboba) in [https://github.com/software-mansion/react-native-screens/pull/1827](https://github.com/software-mansion/react-native-screens/pull/1827) - Update `word-wrap` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1834](https://github.com/software-mansion/react-native-screens/pull/1834) - Format code in test examples by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1812](https://github.com/software-mansion/react-native-screens/pull/1812) - Unify class & method naming with respect to conventions by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1841](https://github.com/software-mansion/react-native-screens/pull/1841) #### New Contributors - [@​piaskowyk](https://github.com/piaskowyk) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1810](https://github.com/software-mansion/react-native-screens/pull/1810) - [@​tboba](https://github.com/tboba) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1823](https://github.com/software-mansion/react-native-screens/pull/1823) **Full Changelog**: software-mansion/react-native-screens@3.22.1...3.23.0 ### [`v3.22.1`](https://github.com/software-mansion/react-native-screens/releases/tag/3.22.1) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.22.0...3.22.1) Patch release bringing back old behaviour of `formSheet` modal on iOS when using `@react-navigation/native-stack`. #### What's Changed ##### Fixes - fix: move setting default values of medium-detent related props to `InnerScreen` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1811](https://github.com/software-mansion/react-native-screens/pull/1811) ##### Internal - chore: fix CI by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1803](https://github.com/software-mansion/react-native-screens/pull/1803) - chore(deps): update selected deps in examples by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1807](https://github.com/software-mansion/react-native-screens/pull/1807) - chore: fix typo in docs by [@​aleqsio](https://github.com/aleqsio) in [https://github.com/software-mansion/react-native-screens/pull/1808](https://github.com/software-mansion/react-native-screens/pull/1808) #### New Contributors - [@​aleqsio](https://github.com/aleqsio) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1808](https://github.com/software-mansion/react-native-screens/pull/1808) **Full Changelog**: software-mansion/react-native-screens@3.22.0...3.22.1 ### [`v3.22.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.22.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.21.1...3.22.0) Minor release fixing some build issues that could happen on older Xcode versions & with Android SDK 34. #### What's Changed - fix: canvas nullability in ScreenStack for Android SDK 34 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1795](https://github.com/software-mansion/react-native-screens/pull/1795) - fix: ifdef orientation code that requries iOS 16 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1794](https://github.com/software-mansion/react-native-screens/pull/1794) - chore: update & reinstall selected deps by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1798](https://github.com/software-mansion/react-native-screens/pull/1798) **Full Changelog**: software-mansion/react-native-screens@3.21.1...3.22.0 ### [`v3.21.1`](https://github.com/software-mansion/react-native-screens/releases/tag/3.21.1) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.21.0...3.21.1) Patch release adding internal `isNewBackTitleImplementation` constant for use in `@react-navigation/native-stack`. See [#​1791](https://github.com/software-mansion/react-native-screens/issues/1791) & [https://github.com/react-navigation/react-navigation/pull/11423](https://github.com/react-navigation/react-navigation/pull/11423) for details. ### [`v3.21.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.21.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.20.0...3.21.0) Minor release with support for React Native 0.72 on New Architecture, fixing some bugs and adding new functionalities. Please note that support for `react-navigation` v4 has been dropped with this version and you can no longer use `native-stack` v4 starting from this version. It might be considered a **BREAKING CHANGE** so be careful with updating. #### What's Changed - chore: migrate codegen to TypeScript by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1600](https://github.com/software-mansion/react-native-screens/pull/1600) - chore: update README on Fabric support by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1687](https://github.com/software-mansion/react-native-screens/pull/1687) - feat(iOS): back button subview for Fabric by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1581](https://github.com/software-mansion/react-native-screens/pull/1581) - fix(iOS): image loading for back button on Fabric by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1688](https://github.com/software-mansion/react-native-screens/pull/1688) - chore: refactor medium detent iOS implementation by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1699](https://github.com/software-mansion/react-native-screens/pull/1699) - feat(Android): add native default animations on Android 13 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1693](https://github.com/software-mansion/react-native-screens/pull/1693) - chore: fix e2e detox tests & `Example` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1681](https://github.com/software-mansion/react-native-screens/pull/1681) - fix(iOS): status bar does not respect app theme by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1708](https://github.com/software-mansion/react-native-screens/pull/1708) - chore(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1709](https://github.com/software-mansion/react-native-screens/pull/1709) - chore: change fabric flag by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1705](https://github.com/software-mansion/react-native-screens/pull/1705) - chore(CI): extend timeout for Android e2e by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1711](https://github.com/software-mansion/react-native-screens/pull/1711) - chore: update deps in examples by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1714](https://github.com/software-mansion/react-native-screens/pull/1714) - chore: update library & examples dependencies by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1721](https://github.com/software-mansion/react-native-screens/pull/1721) - fix: Android build for `compileSdk < 33` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1723](https://github.com/software-mansion/react-native-screens/pull/1723) - feat: add imperative API for search bar by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1610](https://github.com/software-mansion/react-native-screens/pull/1610) - chore(deps): bump shell-quote from 1.6.1 to 1.8.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1725](https://github.com/software-mansion/react-native-screens/pull/1725) - chore: improve Android anim resource management by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1727](https://github.com/software-mansion/react-native-screens/pull/1727) - chore: fix typo in build script by [@​Jace-Samsung](https://github.com/Jace-Samsung) in [https://github.com/software-mansion/react-native-screens/pull/1733](https://github.com/software-mansion/react-native-screens/pull/1733) - chore: set library namespace in build script by [@​Sprimage](https://github.com/Sprimage) in [https://github.com/software-mansion/react-native-screens/pull/1717](https://github.com/software-mansion/react-native-screens/pull/1717) - fix(iOS): back button not respecting style options by [@​tyler-coleman](https://github.com/tyler-coleman) in [https://github.com/software-mansion/react-native-screens/pull/1726](https://github.com/software-mansion/react-native-screens/pull/1726) - chore: override `onCreate` in example apps by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1736](https://github.com/software-mansion/react-native-screens/pull/1736) - feat: add `setText` command on SearchBar by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1739](https://github.com/software-mansion/react-native-screens/pull/1739) - chore(deps): bump activesupport from 6.1.4.6 to 7.0.4.3 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1744](https://github.com/software-mansion/react-native-screens/pull/1744) - fix: do not apply namespace if it is not available in agp by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1749](https://github.com/software-mansion/react-native-screens/pull/1749) - chore(deps): bump vm2 from 3.9.14 to 3.9.15 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1752](https://github.com/software-mansion/react-native-screens/pull/1752) - fix: use new rotation API for iOS 16 by [@​kirillzyusko](https://github.com/kirillzyusko) in [https://github.com/software-mansion/react-native-screens/pull/1732](https://github.com/software-mansion/react-native-screens/pull/1732) - chore: improve Android 13 animations by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1756](https://github.com/software-mansion/react-native-screens/pull/1756) - chore(deps): bump vm2 from 3.9.15 to 3.9.16 by [@​dependabot](https://github.com/dependabot) in [https://github.com/software-mansion/react-native-screens/pull/1755](https://github.com/software-mansion/react-native-screens/pull/1755) - fix: ScreenStackHeaderConfig type by [@​tomekzaw](https://github.com/tomekzaw) in [https://github.com/software-mansion/react-native-screens/pull/1760](https://github.com/software-mansion/react-native-screens/pull/1760) - feat: remove v4 from repo by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1790](https://github.com/software-mansion/react-native-screens/pull/1790) - fix:Compatible with version 0.72 by [@​NiuGuohui](https://github.com/NiuGuohui) in [https://github.com/software-mansion/react-native-screens/pull/1765](https://github.com/software-mansion/react-native-screens/pull/1765) - fix: proper handling of header events on Fabric and bumping examples to 0.72 by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1783](https://github.com/software-mansion/react-native-screens/pull/1783) - feat: prevent native back button dismissal on iOS by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1773](https://github.com/software-mansion/react-native-screens/pull/1773) #### New Contributors - [@​Jace-Samsung](https://github.com/Jace-Samsung) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1733](https://github.com/software-mansion/react-native-screens/pull/1733) - [@​Sprimage](https://github.com/Sprimage) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1717](https://github.com/software-mansion/react-native-screens/pull/1717) - [@​tyler-coleman](https://github.com/tyler-coleman) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1726](https://github.com/software-mansion/react-native-screens/pull/1726) - [@​NiuGuohui](https://github.com/NiuGuohui) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1765](https://github.com/software-mansion/react-native-screens/pull/1765) **Full Changelog**: software-mansion/react-native-screens@3.20.0...3.21.0 ### [`v3.20.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.20.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.19.0...3.20.0) Minior release aimed at fixing [#​1686](https://github.com/software-mansion/react-native-screens/issues/1686) (change of default behaviour for `stackPresentation: 'formSheet'`). No other changes were introduced with this release. Next "feature" release is in preparation. **Full Changelog**: software-mansion/react-native-screens@3.19.0...3.20.0 ### [`v3.19.0`](https://github.com/software-mansion/react-native-screens/releases/tag/3.19.0) [Compare Source](https://github.com/software-mansion/react-native-screens/compare/3.18.2...3.19.0) Minor release with support for React Native 0.71 **Important**: Since this version, Fabric is only supported for React Native 0.71+. Support for older versions has beed dropped. #### 🐛 Bug fixes - Try to apply pointer events behaviors in overlay by [@​WoLewicki](https://github.com/WoLewicki) in [https://github.com/software-mansion/react-native-screens/pull/1582](https://github.com/software-mansion/react-native-screens/pull/1582) - Make enabling device orientation notifications internal by [@​kacperkapusciak](https://github.com/kacperkapusciak) & [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1596](https://github.com/software-mansion/react-native-screens/pull/1596) - Fix back button menu for headerBackTitleVisible prop by [@​kacperkapusciak](https://github.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-screens/pull/1646](https://github.com/software-mansion/react-native-screens/pull/1646) - Override requiresMainQueueSetup in RNSScreenManager by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1670](https://github.com/software-mansion/react-native-screens/pull/1670) #### 👍 Improvements - Support for React Native 0.71.0 by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1631](https://github.com/software-mansion/react-native-screens/pull/1631) - Clarify installation instructions for Android by [@​evan1715](https://github.com/evan1715) in [https://github.com/software-mansion/react-native-screens/pull/1633](https://github.com/software-mansion/react-native-screens/pull/1633) #### 🔢 Miscellaneous - Fix FabricTestExample fails to start due to new `react-native.config.js` by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1624](https://github.com/software-mansion/react-native-screens/pull/1624) - Examples stopped to work after RN issue by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1632](https://github.com/software-mansion/react-native-screens/pull/1632) - Exclude android/.settings file form repo by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1642](https://github.com/software-mansion/react-native-screens/pull/1642) - Bump deps & fix tvOS build by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1667](https://github.com/software-mansion/react-native-screens/pull/1667) - Unify CI between platforms by [@​kkafar](https://github.com/kkafar) in [https://github.com/software-mansion/react-native-screens/pull/1676](https://github.com/software-mansion/react-native-screens/pull/1676) #### New Contributors - [@​evan1715](https://github.com/evan1715) made their first contribution in [https://github.com/software-mansion/react-native-screens/pull/1633](https://github.com/software-mansion/react-native-screens/pull/1633) **Full Changelog**: software-mansion/react-native-screens@3.18.2...3.19.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com>
mccoyplayer
pushed a commit
to mccoyplayer/reactScreen
that referenced
this pull request
Feb 9, 2024
## Description Issues * [x] ~~`activityState` is set to `0.0` by default in codegened files despite being explicitly set to `WithDefault<Float, -1.0>` in config (it should be `-1.0`). Tested it multiple times it looks like you can't set number < 0 for default when using TypeScript - tested with both `Int32` and `Float` (with Flow it worked fine).~~ * [x] ~~`yarn lint` fails~~ * [x] ~software-mansion/react-native-screens#1631 There are no other differences between codegened files -- I checked it file by file with diff tool. Update: It was confirmed by React Native developer that this indeed is a bug and will be fixed with 0.71. Update: * facebook/react-native#34800 was merged and is available is `0.71` rc branches of React Native. ### ***Important note*** Merging this PR will be breaking change for Fabric support for `react-native` versions lower than `0.71.0` (`activityState` & `sheetCornerRadius` will be broken). ## Changes * Migrated codegen spec files from Flow to TS. * Also bumped `@types/react-native` to `0.69.6` [(see explanation)](software-mansion/react-native-screens@d2ed6ec) * Had to do some minor type-fixing in our types * Had to patch `react-navigation-stack` types. This dependency is required for v4. <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce I created a backup of codegened code from before this PR. After applying these changes I ran: `./gradlew :react-native-screens:generateCodegenArtifactsFromSchema` (or just build application) and then I manually compared codegend files using diff checker - the output code is the same. ## Checklist - [x] Ensured that CI passes (there is a known issue with e2e on iOS, it will be handled separately)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that autolinking got complete overhaul in 0.71.0 as
android/app/src/main/jnidirectory was deleted -> thus it works differently for sure now.Still need to dive into it.
FabricTestExample
TestsExample
FabricExample
TODO: Consider whether to use
com.facebook.react:react-native:+orcom.facebook.react:react-native(without+) inandroid/build.gradleof the library.AFAIK the former takes highest available version from defined repositories (should be
node_modules?), the latter uses version injected by React Native Gradle Plugin (but I believe it works since React Native 0.71.0 or 0.70.0 (need to check) -- so version check might be necessary).Decided to leave:
implementation 'com.facebook.react:react-native:+'in library's
android/build.gradledue to following reasons:Blocked by:
Fix variable expansion in ReactNative-application.cmake facebook/react-native#35306Add support for React Native 0.71 react-native-reanimated#3745Support React Native 0.71 react-native-gesture-handler#2313(decided to fix version on commit)react-native-safe-area-context- lacks support for RN71@react-native-community/cli-platform-androidrequires this patch: kkafar/RNS-tester@9edaaa9.The patch is already merged, but it is not shipped with
react-nativeyet.NOTE: Example application will handled in separate PR, as there are problems with detox (it does not support 0.71 yet) and we run CI on that app.
Changes
Test code and steps to reproduce
Run example applications
Checklist