Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Android): Change implementation of headerConfig prop on Android #1883

Merged
merged 2 commits into from
Sep 6, 2023
Merged

fix(Android): Change implementation of headerConfig prop on Android #1883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0545a7e
Change implementation of `headerConfig` prop on Android
tboba Sep 6, 2023
74c4f96
Kotlinize for declaration
tboba Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion android/src/main/java/com/swmansion/rnscreens/Screen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import android.util.SparseArray
import android.view.ViewGroup
import android.view.WindowManager
import android.webkit.WebView
import androidx.core.view.children
import com.facebook.react.bridge.GuardedRunnable
import com.facebook.react.bridge.ReactContext
import com.facebook.react.uimanager.UIManagerModule
Expand Down Expand Up @@ -84,7 +85,7 @@ class Screen constructor(context: ReactContext?) : FabricEnabledViewGroup(contex
}

val headerConfig: ScreenStackHeaderConfig?
get() = getChildAt(0) as? ScreenStackHeaderConfig
get() = children.find { it is ScreenStackHeaderConfig } as? ScreenStackHeaderConfig

/**
* While transitioning this property allows to optimize rendering behavior on Android and provide
Expand Down
Loading