Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Kotlin to 1.9.10 #1904

Closed
wants to merge 1 commit into from
Closed

chore: Update Kotlin to 1.9.10 #1904

wants to merge 1 commit into from

Conversation

tboba
Copy link
Member

@tboba tboba commented Sep 27, 2023

Description

Since we're still using Kotlin 1.8 I think it's a good idea to update kotlin to the newest 1.9.10 version.
Specifically I want to use one of the benefits of this new version in #1903 where I could use new rangeUntil method in for statement.

Checklist

  • Ensured that CI passes

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I've just recently bumped default Kotlin version to 1.8.0 in order to align it with the version in RN application template and potentially fix some localisation issues.

Arguments against bumping the version again & using any fresh syntax (such as rangeUntil):

  1. rnsDefaultKotlinVersion is only a fallback value. It is being used only in case developer did not specify kotlinVersion in their application build.gradle script. And since RN project template specifies this, you should not expect that the library will be compiled with rnsDefaultKotlinVersion Kotlin version.
  2. Using any recent addition to Kotlin would require the library to be compiled with recent compiler --> forcing users to manually bump Kotlin version in their build scripts. We do not really want to do that.

@tboba
Copy link
Member Author

tboba commented Sep 30, 2023

@kkafar great points there, I didn't know that you've already updated Kotlin to 1.8.0 😅
Let's not upgrade it for now then.

@tboba tboba closed this Sep 30, 2023
@tboba tboba deleted the @tboba/update-kotlin branch September 30, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants