Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iOS): select correct VC for nested modal presentation #1912

Merged
merged 17 commits into from
Dec 7, 2023
Merged

fix(iOS): select correct VC for nested modal presentation #1912

merged 17 commits into from
Dec 7, 2023

Commits on Nov 12, 2023

  1. Add reproduction

    @kkafar
    kkafar committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    655f218 View commit details
    Browse the repository at this point in the history

  2. Remove unused compontents part of reproduction

    @kkafar
    kkafar committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    b8edcad View commit details
    Browse the repository at this point in the history

  3. Add partial fix allowing for presenting outer-modal from the inner one

    @kkafar
    kkafar committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    4e59731 View commit details
    Browse the repository at this point in the history

  4. Fix warning by casting pointer to appropriate type

    @kkafar
    kkafar committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    f4d2ada View commit details
    Browse the repository at this point in the history

  5. Add some comments

    @kkafar
    kkafar committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    b41b9ad View commit details
    Browse the repository at this point in the history

  6. Logging

    @kkafar
    kkafar committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    f46811a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Another stash of debug changes

    @kkafar
    kkafar committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    efdd12f View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Remove leftover comment

    @kkafar
    kkafar committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1c8bd7c View commit details
    Browse the repository at this point in the history

  2. Fix it & hold it with a knee so it does not strike back

    @kkafar
    kkafar committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b01b67a View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Merge branch 'main' into @kkafar/modal-issues

    @kkafar
    kkafar committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0bd04ad View commit details
    Browse the repository at this point in the history

  2. Remove logging from RNSScreen

    @kkafar
    kkafar committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    8b29090 View commit details
    Browse the repository at this point in the history

  3. Cleanup & refactor

    @kkafar
    kkafar committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6442a7c View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Merge branch 'main' into @kkafar/modal-issues

    @kkafar
    kkafar committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    c05a66a View commit details
    Browse the repository at this point in the history

  2. Cleanup & finish

    @kkafar
    kkafar committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    ccccc91 View commit details
    Browse the repository at this point in the history

  3. Remove NSLog

    @kkafar
    kkafar committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    dc285c3 View commit details
    Browse the repository at this point in the history

  4. Add Test1829 to FTE & restore Test42 in App.js

    @kkafar
    kkafar committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    4e97739 View commit details
    Browse the repository at this point in the history

  5. Remove leftover comment

    @kkafar
    kkafar committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    6f8b855 View commit details
    Browse the repository at this point in the history