Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support for RN 0.73 #1956

Merged
merged 55 commits into from
Nov 30, 2023
Merged

chore: support for RN 0.73 #1956

merged 55 commits into from
Nov 30, 2023

Commits on Nov 3, 2023

  1. Update package.json

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    8d5b728 View commit details
    Browse the repository at this point in the history
  2. Update Gemfile

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    87309f9 View commit details
    Browse the repository at this point in the history
  3. Update app/build.gradle

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    d762cc3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9a319d1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e8f98b9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    711c5df View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7d4dff3 View commit details
    Browse the repository at this point in the history
  8. Update android/build.gradle

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    531b611 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6074a75 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f1ac0bf View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5f04411 View commit details
    Browse the repository at this point in the history
  12. Update gradle wrapper

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    e54b979 View commit details
    Browse the repository at this point in the history
  13. Update babel.config.js

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    007c29f View commit details
    Browse the repository at this point in the history
  14. Update Podfile

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    5b59a97 View commit details
    Browse the repository at this point in the history
  15. Update iOS project

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    66606cc View commit details
    Browse the repository at this point in the history
  16. Update AppDelegate.mm

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    051bc9d View commit details
    Browse the repository at this point in the history
  17. Update project properties

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    899f6fd View commit details
    Browse the repository at this point in the history
  18. Update tsconfig.json

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    70f8b7e View commit details
    Browse the repository at this point in the history
  19. FTE: Update package.json

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    2b80f0a View commit details
    Browse the repository at this point in the history
  20. FTE: Update Gemfile

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    9e13c93 View commit details
    Browse the repository at this point in the history
  21. FTE & TE: Update build.gradle

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    8e0668e View commit details
    Browse the repository at this point in the history
  22. FTE: Update AndroidManifest

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b4176d3 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    4f4d362 View commit details
    Browse the repository at this point in the history
  24. FTE: Migrate MainActivity

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1e98674 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    c7c6c69 View commit details
    Browse the repository at this point in the history
  26. Typo in MainApplication

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    95fc916 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    507b0d2 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    4e23288 View commit details
    Browse the repository at this point in the history
  29. FTE: Update gradle.properties

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    49bfcdb View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    e677be7 View commit details
    Browse the repository at this point in the history
  31. FTE: Update babel config

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    3f8c524 View commit details
    Browse the repository at this point in the history
  32. FTE: Update Podfile

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    0a969c6 View commit details
    Browse the repository at this point in the history
  33. FTE: Update ios project props

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b8571db View commit details
    Browse the repository at this point in the history
  34. FTE: Migrate AppDelegate.mm

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b9ab475 View commit details
    Browse the repository at this point in the history
  35. FTE: Update project props

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b2b631b View commit details
    Browse the repository at this point in the history
  36. FTE: Update tsconfig

    kkafar committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    4fdfd4a View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    f30efa8 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. fix(android): add buildFeatures.buildConfig true for AGP8+ compat (#1966

    )
    
    ## Summary
    
    Upcoming react-native 0.73+ includes android gradle plugin 8+ which
    needs namespace in build.gradle but also needs buildFeatures.buildConfig
    enabled as well for modules that use it
    
    It is not sufficient to enable this at the top-level app build.gradle,
    specific modules that use it (such as those that implement new
    architecture, it seems) must also enable it at the module level
    
    This change was necessary and is in-use in my work app via patch-package
    as I work through android-gradle-plugin 8+ issues in prep for
    react-native 0.73 launching for everyone
    
    It should be backwards compatible with older gradle plugins in the exact
    same way the previous namespace change was, as it is wrapped in the same
    conditional
    
    It is similar to changes I needed to do as react-native-firebase
    maintainer -->
    invertase/react-native-firebase@b52d0ce
    
    ## Test Plan
    
    ### What's required for testing (prerequisites)?
    
    With apologies, you have to alter an app that integrates this module to
    use android gradle plugin 8, it's difficult to do that in repos I'm
    proposing these changes in because bumping to android gradle plugin 8
    requires a large amount of transitive dependency changes in CI (see
    #1956 !)
    
    I have integrated this in an app and tested it, and done similar work as
    maintainer of react-native-firebase, react-native-netinfo and
    react-native-device-info, and I'm now pushing these out to the repos
    
    ### What are the steps to reproduce (after prerequisites)?
    
    run the build for android
    
    ---------
    
    Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
    mikehardy and kkafar authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1868f8e View commit details
    Browse the repository at this point in the history
  2. doc: add kotlin MainActiviy.kt to instructions (#1971)

    ## Description
    
    RN 0.73 has MainActivity in kotlin not java
    
    ## Changes
    
    - Updated README.md
    
    ---------
    
    Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
    Co-authored-by: Tymoteusz Boba <Tymoteusz.Boba@gmail.com>
    3 people authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    4a44260 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Configuration menu
    Copy the full SHA
    c8ca2fb View commit details
    Browse the repository at this point in the history
  2. Bump to rc 5

    kkafar committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    44f213c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cadb650 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b73937b View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Configuration menu
    Copy the full SHA
    d8e2a9b View commit details
    Browse the repository at this point in the history
  2. fix: build error with rn 0.73-rc.4 (#1972)

    ## Description
    
    Fixes building against react-native 0.73.0-rc4 in fabric mode on android
    
    ## Changes
    
    Updated
    common/cpp/react/renderer/components/rnscreens/RNSScreenComponentDescriptor.h
    to build with fabric on 0.73-rc4.
    
    ## Screenshots / GIFs
    
    ### Before
    
    ### After
    
    ## Test code and steps to reproduce
    
    ```sh
    npx react-native@0.73.0-rc4 init rnscreenstest
    yarn add react-native-screens
    cd android
    # change newArchEnabled to true in `gradle.properties`
    gradlew build
    ```
    
    
    
    ## Checklist
    
    - [ ] Included code example that can be used to test this change
    - [ ] Updated TS types
    - [ ] Updated documentation: <!-- For adding new props to native-stack
    -->
    - [ ]
    https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
    - [ ]
    https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md
    - [ ]
    https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx
    - [ ]
    https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx
    - [ ] Ensured that CI passes
    mfazekas authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3849e2c View commit details
    Browse the repository at this point in the history
  3. Reinstall deps in FTE

    kkafar committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    305ba58 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Configuration menu
    Copy the full SHA
    47a7c05 View commit details
    Browse the repository at this point in the history
  2. Try to fix CI on FTE

    kkafar committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    f491acd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d7c6bc5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    852a86b View commit details
    Browse the repository at this point in the history
  5. Missing endlines

    kkafar committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    007d67a View commit details
    Browse the repository at this point in the history
  6. Uncomment tests in TE

    kkafar committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    5321bd9 View commit details
    Browse the repository at this point in the history
  7. reanimated 3.6.0

    kkafar committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    e4792e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. rc 6 for TE

    kkafar committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    962c93c View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. rc6 for FTE

    kkafar committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    b812bed View commit details
    Browse the repository at this point in the history