Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Android): Fix error about duplicate class ViewModelLazy #1977

Merged
merged 5 commits into from
Nov 29, 2023
Merged

fix(Android): Fix error about duplicate class ViewModelLazy #1977

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ea7f2aa
Fix error about duplicate class ViewModelLazy
tboba Nov 20, 2023
40124ae
Remove unnecessary dependency
tboba Nov 29, 2023
c106177
Update lifecycle-viewmodel-ktx to 2.5.1
tboba Nov 29, 2023
baee8af
Add constraint on lifecycle-viewmodel-ktx:2.5.1 in lib build.gradle
kkafar Nov 29, 2023
96fd792
Correct the reason of constraint
tboba Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,6 @@ dependencies {
implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0'
implementation 'com.google.android.material:material:1.9.0'
implementation "androidx.core:core-ktx:1.8.0"
implementation "androidx.lifecycle:lifecycle-viewmodel:2.5.0"
tboba marked this conversation as resolved.
Show resolved Hide resolved
implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I checked those deps right now I observed that "androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.0" could be sufficient, but in my opinion we should ensure that both of these libraries should have the same version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

androidx.lifecycle:licecycle-viewmodel:2.5.0 is a direct dependency of androidx.lifecycle:lifecycle-viewmodel-ktx:2.5.0. There is no need to specify it.

See here: https://androidx.tech/artifacts/lifecycle/lifecycle-viewmodel-ktx/2.5.0

}
Loading